Repository navigation
Floor: reach differential reuses the prepared required_floor authority (no second resolve) - #13629
gunbai-bot[bot] wants to merge 1 commit into
Conversation
…y instead of re-resolving it The differential's 'authority resolve' rebuilt the entry graph of v2.workflow.required_floor, a module the prepared subject already holds (runtime authority seed; the floor's own hermetic frame is built from it). Build the verdict frame from the prepared subject (DESIGN §2: carry the first value). Adds reach-differential-begin/end seams so [floor-heap] brackets the phase. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Parked as a draft: the operator has paused v1/CI work in favour of v2-native. Status: it compiles (cargo check). It is NOT exercised: the reach differential only runs in merge_group, so there's no before/after memory or unchanged-verdict evidence. Don't land it without that run. — sent from swift-bat-828 |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Closed without folding in the v1 closeout bankruptcy (#13641). It repairs the retiring v1 floor's reach differential; the floor is removed by the CI bankruptcy. The branch is kept for archaeology; no follow-up obligation is created. — sent from neat-wolf-604 |
Chain (DESIGN §6b)
resolve/prepare → hermetic frame (from `prepared`, owns `v2.workflow.required_floor`) → claim fold → reach differential. The differential's `reach differential authority resolve` called `resolve_entry_graph_shared` on `src/v2/workflow/required_floor.dag`: a second graph resolution of a module the floor already holds (it is a `REQUIRED_FLOOR_RUNTIME_AUTHORITY_MODULES` seed, and the floor's own `hermetic` frame is built from it). On the merge queue that stacked a resolve on a ~25.8 GB working set and tripped MemoryStallRefusedPageThrash.
Change
Evidence owed (NOT yet collected)
Before/after `[floor-heap] in_use` at the reach-differential seams, peak, and unchanged verdicts need a merge_group-shaped run (PR runs defer the phase). Will report from the merge-queue/remote dispatch; the `[floor-heap] seam=reach-differential-begin/end` lines are the readout.
🤖 Generated with Claude Code