Repository navigation
emit_host shell-exec witness: match Optional from first() instead of comparing to a string - #13619
Merged
Merged
Conversation
… of comparing it to a string shell_exec_run_eval_expected_octet compared skip(n).first(), an Optional<String>, directly with "bash" and "-s". The type checker rejects that, and the refusal is failing every merge group whose floor subject reaches this module (e.g. runs 37882164000, 37882176272). Same correction as the one inside #13549, extracted so the queue isn't held behind that 43-file PR. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the floor refusal currently failing merge groups (runs 37882164000, 37882176272). In
src/v2/test/claim/execution/emit_host_shell_exec_run_equals_eval_test.dag,shell_exec_run_eval_expected_octetcomparedskip(n).first(), which is anOptional<String>, directly with"bash"and"-s". The code is already on main; a merge group fails whenever its floor subject reaches this module.This is the same correction #13549 carries for this function: match
Present/Absent, whereAbsentis false. It's extracted into a one-file PR so the queue isn't held behind #13549's 43 files. It also addsimport std.optional { Present, Absent }.Not run locally: gunbc refuses to run on the remote builder without a cgroup memory limit. This PR's floor compiles the touched module, and that run is the verification.
🤖 Generated with Claude Code