Repository navigation
Tailscale ACL: admit tag:dashboard to the dusk-1 serving API (tcp:8080) #13613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| {"grants": [{"src": ["autogroup:member"], "dst": ["*"], "ip": ["*"]}, {"src": ["tag:ci"], "dst": ["100.65.94.55", "tag:dashboard"], "ip": ["tcp:3737"]}, {"src": ["tag:dashboard"], "dst": ["tag:dashboard"], "ip": ["*"]}, {"src": ["tag:dashboard"], "dst": ["tag:ci"], "ip": ["tcp:22"]}], "ssh": [{"action": "accept", "src": ["autogroup:member"], "dst": ["autogroup:self"], "users": ["autogroup:nonroot", "root"]}, {"action": "accept", "src": ["autogroup:member"], "dst": ["tag:ci"], "users": ["autogroup:nonroot"]}, {"action": "accept", "src": ["tag:dashboard"], "dst": ["tag:ci"], "users": ["autogroup:nonroot", "root"]}], "nodeAttrs": [{"target": ["autogroup:member"], "attr": ["funnel"]}], "tagOwners": {"tag:ci": ["autogroup:admin"], "tag:dashboard": ["autogroup:admin"]}} | ||
| {"grants": [{"src": ["autogroup:member"], "dst": ["*"], "ip": ["*"]}, {"src": ["tag:ci"], "dst": ["100.65.94.55", "tag:dashboard"], "ip": ["tcp:3737"]}, {"src": ["tag:dashboard"], "dst": ["tag:dashboard"], "ip": ["*"]}, {"src": ["tag:dashboard"], "dst": ["tag:ci"], "ip": ["tcp:22"]}, {"src": ["tag:dashboard"], "dst": ["100.127.39.77"], "ip": ["tcp:8080"]}], "ssh": [{"action": "accept", "src": ["autogroup:member"], "dst": ["autogroup:self"], "users": ["autogroup:nonroot", "root"]}, {"action": "accept", "src": ["autogroup:member"], "dst": ["tag:ci"], "users": ["autogroup:nonroot"]}, {"action": "accept", "src": ["tag:dashboard"], "dst": ["tag:ci"], "users": ["autogroup:nonroot", "root"]}], "nodeAttrs": [{"target": ["autogroup:member"], "attr": ["funnel"]}], "tagOwners": {"tag:ci": ["autogroup:admin"], "tag:dashboard": ["autogroup:admin"]}} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
grant_reaches_dusk_servingrecognizes only a literal100.127.39.77destination, but the existingmember_baseline_grantusesdst: [sel_wildcard()]andip: [sel_wildcard()]. Tailscale defines a destination wildcard as matching all tailnet IP addresses and anipwildcard as matching every protocol and port (Tailscale selector reference), so the emitted policy lets every member reach dusk-1 on all ports while this new security-spine predicate reports that onlytag:dashboardcan reach TCP 8080. Account for wildcard destinations (and any modeled ranges containing this address) in this reachability check and its negative witness.Useful? React with 👍 / 👎.