Repository navigation
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iam_bootstrap_applycannot create the fleet convergence pool from #13509: GCP rejects its 36-character display name because the limit is 32. Shorten the label to the 24-characterFleet convergence (main). Pool/provider IDs, claim restrictions, service accounts, and IAM bindings are unchanged.Validation:
git diff --checkand the pre-pushcargo fmt --all --checkpassed. The corrected live bootstrap completed all ten stages; independent readback verified all 58 declared bindings and removal of both temporary probe grants. The printed bootstrap plan was byte-for-byte unchanged. The subsequent approval-gated fleet-converge run, attempt 2 succeeded, with independent verification of the providers and final grants.