Skip to content

witnesses: match optional results instead of comparing T? == T (3 files) #13600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
briansrls wants to merge 1 commit into from
+5 −5
Closed

witnesses: match optional results instead of comparing T? == T (3 files) #13600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dag/test/claim/cloudflare_r2_token_witness_test.dag
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,13 +204,13 @@ test fn r2_object_read_create_request_cites_the_documented_permission_group_id()
bucket_name: "my-bucket"
)
(policy.permission_groups |> count) == 1
&& (policy.resources |> get(
&& (match policy.resources |> get(
r2_bucket_resource_name(
account_id: "4793d734c0b8e484dfc37ec392b5fa8a",
jurisdiction: R2JurisdictionDefault,
bucket_name: "my-bucket"
)
)) == "*"
) { Present { value: v } => v == "*" Absent => false })
&& all(
policy.permission_groups,
g => g.id == workers_r2_storage_bucket_item_read_permission_group_id
Expand Down
4 changes: 2 additions & 2 deletions dag/test/claim/host/host_converge_slice1_witness_test.dag
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,8 +149,8 @@ test fn witness_enumerate_units_uses_typed_list_units_op() -> Bool {
match systemctl_list_units_active_services(instance_glob: "actions-runner@srv3-*.service" as NonEmptyStr) {
Present { value: units } =>
length(units) == 2
&& units.first() == "actions-runner@srv3-01.service" as NonEmptyStr
&& units.skip(n: 1).first() == "actions-runner@srv3-02.service" as NonEmptyStr
&& (match units.first() { Present { value: u } => u == "actions-runner@srv3-01.service" as NonEmptyStr Absent => false })
&& (match units.skip(n: 1).first() { Present { value: u } => u == "actions-runner@srv3-02.service" as NonEmptyStr Absent => false })
Absent => false
}
}
Expand Down
2 changes: 1 addition & 1 deletion dag/test/claim/machine_intake/mtcollins1_physical_orientation_witness_test.dag
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ fn resolves_to(anchors: List<DimmPlacementAnchor>, banks: List<MtCollinsDimmFigu
// socket), and the firmware trained SK0 MC0 S0 and SK0 MC4 S0.
test fn w_unmirrored_figure_order_contradicts_firmware() -> Bool {
match anchor_verdict(anchor: mtcollins1_three_stick_anchor, hypothesis: FigureOrder, banks: dimm_figure_banks, pairs: mt_collins_channel_connector_pairs) {
AnchorContradicted { predicted: p } => list_length(items: p) == 1 && p.first().socket == 0 && p.first().controller == 0
AnchorContradicted { predicted: p } => list_length(items: p) == 1 && (match p.first() { Present { value: b } => b.socket == 0 && b.controller == 0 Absent => false })
AnchorConsistent => false
AnchorUnevaluable { unresolved_key: _ } => false
AnchorFrameUnreported => false
Expand Down
Loading