Skip to content

Delete the v2 packrat parse memo carrier (R2, stacked on #13577) #13582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
briansrls wants to merge 3 commits into from
Closed

Delete the v2 packrat parse memo carrier (R2, stacked on #13577) #13582

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
55eb006
Delete the v2 packrat parse memo carrier (operator ruling R2, 2026-10…
Oct 8, 2026
be39cab
Compare supplied stream layouts by their recorded line breaks (Stream…
Oct 8, 2026
427b080
Assert each terminal resolves through its own id to its own bytes, in…
Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions dag/extdeps/cache.dag
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import extdeps.cache.types {
CatalogOpaqueStringKey,
CatalogCasContentDigest,
}
import extdeps.realization.parse_table_memo { parse_table_memo_facts, parse_table_memo_id }
import extdeps.realization.compile_stage_memo { compile_stage_memo_facts, compile_stage_memo_id }
import extdeps.realization.reconcile_in_process {
parse_cache_facts,
Expand Down Expand Up @@ -128,7 +127,6 @@ data sccache_local: CacheInterfaceCatalogFacts = sccache_local_facts
data buildbuddy_cas: CacheInterfaceCatalogFacts = buildbuddy_cas_facts
data cargo_target_dir: CacheInterfaceCatalogFacts = cargo_target_dir_facts
data rustup_toolchain_store: CacheInterfaceCatalogFacts = rustup_toolchain_store_facts
data parse_table_memo: CacheInterfaceCatalogFacts = parse_table_memo_facts
data compile_stage_memo: CacheInterfaceCatalogFacts = compile_stage_memo_facts

data cache_catalog: List<CacheInterfaceCatalogFacts> = [
Expand All @@ -139,7 +137,6 @@ data cache_catalog: List<CacheInterfaceCatalogFacts> = [
rustup_toolchain_store,
parse_cache_facts,
typed_module_cache_facts,
parse_table_memo,
compile_stage_memo_facts,
materialization_store_local_facts,
]
Expand All @@ -148,17 +145,16 @@ data cache_catalog_rows: List<CacheInterfaceFacts> = cache_catalog
|> map(row => cache_interface_facts_from_catalog(row: row))

data sccache_local_projected: CacheInterfaceFacts = cache_interface_facts_from_catalog(sccache_local)
data parse_table_memo_projected: CacheInterfaceFacts = cache_interface_facts_from_catalog(parse_table_memo)
data compile_stage_memo_projected: CacheInterfaceFacts = cache_interface_facts_from_catalog(compile_stage_memo)
data cargo_target_dir_projected: CacheInterfaceFacts = cache_interface_facts_from_catalog(cargo_target_dir)

data cache_layer_default_order: List<CacheInterfaceId> = [
parse_table_memo_id,
compile_stage_memo_id,
parse_cache_id,
typed_module_cache_id,
cargo_target_dir_id,
sccache_local_id,
rustup_toolchain_store_id,
buildbuddy_cas_id,
gha_actions_cache_id,
compile_stage_memo_id,
]
89 changes: 0 additions & 89 deletions dag/extdeps/realization/parse_table_memo.dag
View file
Open in desktop

This file was deleted.

Loading