Skip to content

os_install_actuator_selection witness: pin the declared rosters by whole-list equality #13573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gunbai-bot wants to merge 2 commits into from
Closed

os_install_actuator_selection witness: pin the declared rosters by whole-list equality #13573

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ad332d
os_install_actuator_selection witness: compare optional first() again…
Oct 8, 2026
a39504a
os_install_actuator_selection witness: pin the declared rosters by wh…
Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions dag/test/claim/os_install_actuator_selection_witness_test.dag
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,18 @@ module test.claim.os_install_actuator_selection

data live_tree_disposition: LiveTreeDisposition = SubstrateInputsOnly

// The dispatch consumes the kind rows in declaration order; pin the declared
// roster by whole-list equality. List.first() cannot be used here: the checker
// types it T? (#13179) while the executing runtime returns the bare element
// (the fork recorded in cross_type_comparison_answers_instead_of_refusing), so
// no first()-based comparison both type-checks and executes true.
test fn os_install_actuator_requirements_dispatch_through_kind_rows() -> Bool {
os_install_actuator_requirement_kinds.first() == BmcNetworkReach
&& os_install_actuator_requirement_kinds.skip(n: 1).first() == ActuatorToolchainGrant
os_install_actuator_requirement_kinds == [
BmcNetworkReach,
ActuatorToolchainGrant,
InstallMediaArtifactRealizable,
InstallWindowAvailability,
]
&& os_install_actuator_requirement_satisfied(
kind: BmcNetworkReach,
candidate: srv1_host,
Expand All @@ -26,8 +35,7 @@ test fn srv3_actuator_host_selected_because_requirements_and_policy() -> Bool {
&& srv3_os_install_actuator_host_is_derived_srv1()
&& match srv3_os_install_actuator_tie_break_policy {
OperatorHostPreference { order: order } =>
order.first() == operator_host_srv1
&& order.skip(n: 1).first() == operator_host_srv2
order == [operator_host_srv1, operator_host_srv2]
_ => false
}
}
Expand Down
Loading