Repository navigation
Skip module-surface members in reference-derived residency reading - #13566
Closed
gunbai-bot[bot] wants to merge 4 commits into
Closed
gunbai-bot[bot] wants to merge 4 commits into
gunbai-bot[bot] wants to merge 4 commits into
Conversation
A module or namespace is not a record payload: judge binders only on stamped module surfaces (declaration identity, graft-body stamp, or header production edge), and keep CarrierMemberNotABinder for a genuine hand-built field. Co-authored-by: Cursor <cursoragent@cursor.com>
4 of 6 tasks
#13560 owns the languages.dag predicates until that skip is constructional on a landed head. Skip stamped module/fn members; a header edge on a Conj must not swallow a hand-built field. Co-authored-by: Cursor <cursoragent@cursor.com>
The residency lens was carrying a four-identity copy and omitting data/type/alias declarations; the skip is now one parse-identity predicate, still not a Conj-wide container skip. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
Addressed review 77869 (#13566, dashboard artifact /api/reviews/77869/artifacts/stdout.log):
— sent from sunny-stag-900 |
One production list now feeds the module-item choice, the residency skip, and iard_is_declaration. Module surface and the graft-body stamp stay the only extras. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
Addressed review 77878 (dashboard artifact /api/reviews/77878/artifacts/stdout.log): Top-level declaration identities are no longer a hand-copied — sent from sunny-stag-900 |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v2.lens.reference_derived_residency_readingno longer treats a module/namespace Authored member as a record field that failed to be a binder.v2.extdeps.languages.dagby declaration identity, graft-body stamp, ordag_surface_module_headerproduction edge — not by children shape.CarrierMemberNotABinder. This lens is not enrolled onrequired_compile_lens_roster.Test plan
v2.test.claim.reference_derived_residency_readinga_module_container_is_not_read_as_a_non_binder_recordanda_hand_built_record_field_still_reports_member_not_a_binderv2.test.claim.edge_label.structural_label_readersstamp vs children-shape claimsMade with Cursor