Repository navigation
Conversation
…mbers, BMC 3.22.00 digest Four operator-supplied Drive archives (BIOS 4.01 TAR and ROM, SCP 2.10.20260210 OpenBMC tar and Instant Flash slim) join gunbc.altra_firmware_library under a BetaFirmwareDistribution subject naming the exact beta listing, which extdeps.boards.asrock_altrad8ud_beta_firmware now names row by row. altra_firmware_archive_members records the flashable member inside each firmware archive (name, bytes, sha256, OpenBMC MANIFEST version), because a flash consumes the member, not the zip. The SCP archive named 2.10.20260210 carries obmc-scp-altrad8ud-1l2t-4.01.tar whose MANIFEST reads version=4.01, Type=scp, so a BMC read-back of that push reports 4.01. asrock_altrad8ud_bmc_3_22_00_release gains its measured archive digest and size (replacing image_digest: Absent) and its static.mtd.tar push member; that member was pushed to srv13 on 2026-10-08 and its inventory then read 3.22.00. Witness: altra_firmware_library 5/5 (two new: every firmware archive has exactly one member by identity in both directions; the SCP push member declares 4.01). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 746014b5e0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| image_bytes: byte_size(count: 29060210), | ||
| image_digest: Present { |
There was a problem hiding this comment.
When an operator consults this firmware catalog, the release now carries a measured byte count and Present digest, but the provenance block immediately below still says this row is digest-Absent, that its size is only the page's rounded value, and that it must not be treated as an acquired artifact (lines 481–483). This leaves the safety-sensitive flashing guidance contradicting the data introduced here; update that block to describe the Drive-acquired archive and clearly retain only any still-unobserved vendor-locator limitation.
Useful? React with 👍 / 👎.
| hex: "cb8b8e727174b8383f90f36e967838c46105bd42bc76cc08c4ac1383a88ca9de", | ||
| ) | ||
|
|
||
| data asrock_altrad8ud_bmc_3_22_00_manifest_purpose: NonEmptyStr = "xyz.openbmc_project.Software.Version.VersionPurpose.BMC" |
There was a problem hiding this comment.
A repo-wide use search finds this new datum only at its declaration: unlike the adjacent artifact name, size, and digest, it is not imported into altra_firmware_library, and AltraLibraryMember.manifest records only the version. As a result, invoking the stated write_reference_report operator route drops the typed BMC-purpose fact entirely, leaving a dangling declaration that cannot affect execution or validation; carry it through the member/report model and witness it, or remove the unused row.
Useful? React with 👍 / 👎.
1 participant
Four operator-supplied Drive archives (BIOS 4.01 TAR and ROM, SCP 2.10.20260210
OpenBMC tar and Instant Flash slim) join gunbc.altra_firmware_library under a
BetaFirmwareDistribution subject naming the exact beta listing, which
extdeps.boards.asrock_altrad8ud_beta_firmware now names row by row.
altra_firmware_archive_members records the flashable member inside each
firmware archive (name, bytes, sha256, OpenBMC MANIFEST version), because a
flash consumes the member, not the zip. The SCP archive named 2.10.20260210
carries obmc-scp-altrad8ud-1l2t-4.01.tar whose MANIFEST reads version=4.01,
Type=scp, so a BMC read-back of that push reports 4.01.
asrock_altrad8ud_bmc_3_22_00_release gains its measured archive digest and size
(replacing image_digest: Absent) and its static.mtd.tar push member; that
member was pushed to srv13 on 2026-10-08 and its inventory then read 3.22.00.
Witness: altra_firmware_library 5/5 (two new: every firmware archive has
exactly one member by identity in both directions; the SCP push member
declares 4.01).
🤖 Generated with Claude Code