Repository navigation
Delete dead emit_resolve_transitively_fn stamp from generated main - #13520
gunbai-bot[bot] wants to merge 3 commits into
Conversation
…o generated main. The emitted import-line BFS omitted reference-only providers. Generated resolve_transitively_with_seen now calls resolve_seeded_compile_closure. RED: production text names that authority and not extract_import_paths(&content). Co-authored-by: Cursor <cursoragent@cursor.com>
Generated main already compiles through cli_run::compile_emission; the stamped walker and extract_import_paths had no callers. The string-literal mutant over that stamp was permanently green. Co-authored-by: Cursor <cursoragent@cursor.com>
|
review 38602 is right on both findings. The Deleted — sent from quiet-eagle-374 |
|
Verified review 77332 (claude/opus APPROVE) against Call sites: The two — sent from quiet-eagle-374 |
…e' into fix/emit-resolve-transitively
Summary
cli_run::compile_emission.emit_resolve_transitively_fn/emit_extract_import_paths_fnstamped an unused import-line walker (resolve_transitively_with_seen) with no callers. Deleted rather than rewritten (review 38602).Receipts on
9b25ca28f7//gunbc/instruments:self-host: held.exit_status=0warning_count=0wall_s=873. Driver refused the poison specimen (tokenize_lex_e1_unrecognized_char).//gunbc/instruments:emitted-crate-workspaceunder a 48GiB cgroup leaf (memory.max=51539607552): stillEmittedWorkspaceClosuresDisagreeoutside_dag=v2_std_layer,v2_std_refinement,dry_run(not_emittedempty, 240 files). Same refusal after the stamp was deleted.outside_dagnames onorigin/mainaa3f1dddbcand on compiler_tests resolve_source_closure: close through the compile-closure authority #13518ea1a22c3c1. This disagreement pre-exists Delete dead emit_resolve_transitively_fn stamp from generated main #13520 (seed emit iscompile_entry_emission/ both-closure; the plan isemitted_compiler_closure_module_dagoverdependency_resolution_facts_live). Not a land blocker for this deletion.HostBudgetUnreadable; EstimatedMemory cannot invent a cap.Two causes in that
outside_dagtriplev2_std_layerandv2_std_refinementare DAG modules the seed emit includes (both-closure) and the plan omitted (ImportBearingondependency_resolution_facts_live). Fix is Producer fix: dependency_resolution_facts unions reference edges for import-bearing files #13526 (producer union independency_resolution_facts), not a per-consumer reroute ofemitted_workspace_plan.dry_runis separate:emit_dry_run_modulein05_emit_rust.dagwritessrc/dry_run.rswhenhas_services. It is not a.dagmodule. That exception also lands in Producer fix: dependency_resolution_facts unions reference edges for import-bearing files #13526 so the instrument integration control can clear completely. Closed Route emitted-crate-workspace plan through compile-entry both-closure #13528 duplicated that work.Test plan
ctrl-build --remote -- cargo clippy --all-targets -- -D warningson9b25ca28f79b25ca28f7Made with Cursor