Skip to content

Delete dead emit_resolve_transitively_fn stamp from generated main - #13520

Open
gunbai-bot[bot] wants to merge 3 commits into
fix/compiler-tests-source-closurefrom
fix/emit-resolve-transitively
Open

gunbai-bot[bot] wants to merge 3 commits into
fix/compiler-tests-source-closurefrom
fix/emit-resolve-transitively

Conversation

@gunbai-bot

@gunbai-bot gunbai-bot Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Receipts on 9b25ca28f7

  • //gunbc/instruments:self-host: held. exit_status=0 warning_count=0 wall_s=873. Driver refused the poison specimen (tokenize_lex_e1_unrecognized_char).
  • //gunbc/instruments:emitted-crate-workspace under a 48GiB cgroup leaf (memory.max=51539607552): still EmittedWorkspaceClosuresDisagree outside_dag=v2_std_layer,v2_std_refinement,dry_run (not_emitted empty, 240 files). Same refusal after the stamp was deleted.
  • Same three outside_dag names on origin/main aa3f1dddbc and on compiler_tests resolve_source_closure: close through the compile-closure authority #13518 ea1a22c3c1. This disagreement pre-exists Delete dead emit_resolve_transitively_fn stamp from generated main #13520 (seed emit is compile_entry_emission / both-closure; the plan is emitted_compiler_closure_module_dag over dependency_resolution_facts_live). Not a land blocker for this deletion.
  • Without a cgroup, the instrument path is HostBudgetUnreadable; EstimatedMemory cannot invent a cap.

Two causes in that outside_dag triple

Test plan

Made with Cursor

Brian Searls and others added 2 commits October 6, 2026 23:35
…o generated main.

The emitted import-line BFS omitted reference-only providers. Generated resolve_transitively_with_seen now calls resolve_seeded_compile_closure. RED: production text names that authority and not extract_import_paths(&content).

Co-authored-by: Cursor <cursoragent@cursor.com>
Generated main already compiles through cli_run::compile_emission; the stamped walker and extract_import_paths had no callers. The string-literal mutant over that stamp was permanently green.

Co-authored-by: Cursor <cursoragent@cursor.com>
@gunbai-bot

gunbai-bot Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

review 38602 is right on both findings.

The import_only_emitted_resolve mutant was a hardcoded string and never called emit_resolve_transitively_fn. resolve_transitively_with_seen had no call site: retained-host compile already goes through cli_run::compile_emission, same census main.rs recorded when those helpers lost their callers.

Deleted emit_resolve_transitively_fn and the orphaned emit_extract_import_paths_fn stamp (and the string tests) instead of rewriting them. 9b25ca28f7.

— sent from quiet-eagle-374

@gunbai-bot gunbai-bot Bot changed the title emit_resolve_transitively_fn: stamp the compile-closure authority Delete dead emit_resolve_transitively_fn stamp from generated main Oct 7, 2026
@gunbai-bot

gunbai-bot Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

Verified review 77332 (claude/opus APPROVE) against 9b25ca28f7.

Call sites: emit_resolve_transitively_fn / emit_extract_import_paths_fn are gone from both 05_emit_rust.dag (emit_main_pipeline_fns now concatenates collect/extract_module_path/dep_pool/compile_target_helpers only) and v1_compiler_emit_rust.rs. Tree grep for those names hits only the namespace-cut plan sentence that records the deletion. Remaining extract_import_paths( calls are cli_run / entry_resolve, not the deleted stamp.

The two resolve_transitively_with_seen mentions stay. src/v1/stage0/src/main.rs is already past-tense census of the handler deletion (were this handler's private … machinery). real_ingest_test.dag is a 2026-07-20 TEMPORARY note about pool-pull; rewriting it is that dissolution, not this stamp deletion. Not touching them here.

— sent from quiet-eagle-374

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants