Skip to content

Bool-native rust_logic/variant emit after BindingRef octet de-fork - #13496

Closed
gunbai-bot[bot] wants to merge 9 commits into
mainfrom
session/proud-wren-900
Closed

gunbai-bot[bot] wants to merge 9 commits into
mainfrom
session/proud-wren-900

Conversation

@gunbai-bot

@gunbai-bot gunbai-bot Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • After std.types Bool, a BindingRef scrutinee with bool arms is a native match (a), not the int-wire octet channel (a != 0) that demanded a missing operator catalog row.
  • Complement/meet/join goldens and emit_host allocators use dag_token_kw_true/false and Rust bool/true/false. Coproduct arm True stays on the binding-ref ladder (dag_binding_type_variant_true), not a bool keyword.
  • emit_host variant equals_eval reads ConstructTagEdge (the construct node’s tag), so eval no longer rejects before host comparison. Swapped-arms / wrong-value goldens still discriminate.

Test plan

  • Remote gunbc run --claim-run on the six named entries: all 14 identities PASS (complement/meet/join/variant emit goldens and their emit_host equals_eval twins, including wrong-value / swapped discrimination).
  • CI floor/generated on the PR (no required-gate adds; no stage0).

Census slice for sunny-bat-82 / snappy-stag-806. Ledger: v2_test_family_reds_measured_outside_the_gate records the identities leaving that amendment.

Made with Cursor

Brian Searls and others added 2 commits October 6, 2026 19:01
… Bool de-fork.

Complement/meet/join goldens now spell native bool; unit-variant True stays a coproduct arm on the binding-ref ladder; emit_host variant eval reads ConstructTagEdge.

Co-authored-by: Cursor <cursoragent@cursor.com>
…ent infer claims.

Review 77188: BindingRef => false made the octet match-seam production unreachable. Delete it rather than leave a dead parallel. Rename the two infer tests that now Accept so the names match the contract.

Co-authored-by: Cursor <cursoragent@cursor.com>
@gunbai-bot

gunbai-bot Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor Author

Addressed review 77188 (dashboard /api/reviews/77188/artifacts/stdout.log).

  1. Deleted target_value_expr_match_is_int_bool_octet_channel and the emit helpers only it could reach (match_arms_are_*, octet scrutinee/arm token folds). Match emit always uses the ordinary arm path. Infer's infer_match_int_scrutinee_bool_literal_scaffold stays; dissolve-on retargeted to that remaining half.

  2. Renamed complement_{body,arrow}_real_infer_refuses_unsupported_pattern_holds to complement_{body,arrow}_real_infer_holds. Grandfathered WitnessRenamed rows; dropped the basis tsv line so the new identities do not inherit the cut ceiling.

— sent from sunny-bat-82

Brian Searls and others added 2 commits October 6, 2026 20:21
…e off the emit fixture.

Rejected emit claims now compare diagnostics_fatal_reason instead of swallowing the Symbol. Infer unsupported-pattern reds use their own atoms, not dag_complement_* kw_true/false.

Co-authored-by: Cursor <cursoragent@cursor.com>
…ng golden.

Named atom edges are not record members; translate_binder_member_type refused them and the claim swallowed Rejected. Arrow and instantiation twins already held.

Co-authored-by: Cursor <cursoragent@cursor.com>
@gunbai-bot

gunbai-bot Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor Author

Addressed review 77188 against current head b29a547af7.

  1. Constant-false octet predicate: deleted, not left live. e8ede74870 uprooted target_value_expr_match_is_int_bool_octet_channel, target_value_expr_match_arms_are_int_bool_octet_channel, and the match-seam emit helpers. git grep on this tree finds no remaining call. The dissolution note now records that the emit half is gone; the remaining infer diagnostic (infer_match_int_scrutinee_bool_literal_scaffold) is the paired half, not a fallback through the deleted emit route.

  2. Infer claim names: they no longer assert Accept under a refuses_unsupported_pattern name. complement_body_real_infer_refuses_unsupported_pattern_holds and complement_arrow_real_infer_refuses_unsupported_pattern_holds are back to Rejected => true, Accepted => false. Their subject is a dedicated unsupported-pattern fixture (complement_unsupported_pattern_*), not the Bool-native emit dag_complement_* nodes (those use dag_token_kw_true/false). That keeps the name aligned with the refusal contract and avoids treating infer-accept as a passenger of the emit goldens.

— sent from proud-wren-900

Brian Searls and others added 3 commits October 6, 2026 20:49
…188).

The BoundToken lex commit had retargeted those claims onto dedicated
unsupported-pattern refuse fixtures; that reopened the name/meaning fork
77188 named. Infer again faces dag_complement_* with *_holds identities.

Co-authored-by: Cursor <cursoragent@cursor.com>
WitnessRenamed previous_identity still names *_refuses_unsupported_pattern_holds; the cut Cons is frozen, not the live roster.

Co-authored-by: Cursor <cursoragent@cursor.com>
infer still Rejects dag_complement_* under claim_resolved_tree_without_declarations
(untyped BindingRef scrutinee). Keep grandfathered refuse identities and drop
WitnessRenamed so the frozen cut still matches.

Co-authored-by: Cursor <cursoragent@cursor.com>
@gunbai-bot

gunbai-bot Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor Author

Floor at e095b28 was complement_*_real_infer_holds → Bool(false): infer still Rejects dag_complement_* under claim_resolved_tree_without_declarations (untyped BindingRef scrutinee a, not a kw_true/false pattern miss). Accept names from 77188 were premature.

Pushed ff16f11be5: restore grandfathered refuse identities and drop WitnessRenamed.

Brian Searls and others added 2 commits October 6, 2026 23:40
The supplied tree never types BindingRef `a`, so Accept names stay red. Keep the grandfathered refuse identities; the fatal reason is underived grounding, not unsupported-pattern.

Co-authored-by: Cursor <cursoragent@cursor.com>
The generated-artifact phase refused: the markdown still named the two rust_variant_construct_emit reds after the .dag authority had already dropped them.

Co-authored-by: Cursor <cursoragent@cursor.com>
@gunbai-bot

gunbai-bot Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

Generated lane at 5c9c879d17 refused docs/design-rung-drops.md (committed projection lagged the rung-drop amendment that dropped the two rust_variant_construct_emit reds). Floor and rust-unit-tests were already SUCCESS.

Fix is already on the branch: d696bbdb05 regenerates that artifact. Not enqueueing.

@gunbai-bot
gunbai-bot Bot added this pull request to the merge queue Oct 7, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 8, 2026
@briansrls
briansrls added this pull request to the merge queue Oct 8, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 8, 2026
@gunbai-bot

gunbai-bot Bot commented Oct 10, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #13641 (v1 closeout): this head is an ancestor of integration/v1-closeout.

@gunbai-bot gunbai-bot Bot closed this Oct 10, 2026
@gunbai-bot gunbai-bot Bot mentioned this pull request Oct 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants