Repository navigation
AOE admission wall: named domain fixtures use binder_edge - #13470
Merged
Merged
Conversation
Resolve now requires type_binder_labels_conform, so a declared-order control whose binders were bare Atoms was refused as malformed_tree and the claim went red. The no-order specimen still has no producer. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
arrow_order_edge/admission_wall_test.dag aoe_resolve_refuses_a_named_domain_without_order(pin 9bb7440).resolverefuses unlesswell_formedandtype_binder_labels_conform. The positive control useddeclared_signatureoverAuthored → Atombinders, so resolve refused it asresolve_reason_malformed_treeand the claim failed. Production lowering mintsbinder_edge. The no-order RED is still hand-built with no producer; it still lacks an order edge.Test plan
aoe_well_formed_*/aoe_infer_*/aoe_assembly_gate_*still discriminate the three arrowsMade with Cursor