Repository navigation
Fix main: four namespace_xl0 test modules read the removed NativeTestFileRefusal.fatal_reason (use the chain-derived accessor) - #13400
Merged
Conversation
…est_file_refusal_fatal_reason (the stored field was removed by #13364; the modules sit outside the floor's gate closure) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 5, 2026
This was referenced Oct 6, 2026
gunbai-bot Bot
pushed a commit
that referenced
this pull request
Oct 7, 2026
…/vivid-lynx-377-map-get-fork
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a silent red on main from #13364 (457d06d). #13364 removed
NativeTestFileRefusal's storedfatal_reason, but four test modules still readrefusal.fatal_reason, so they no longer typecheck. Each module sits outside the floor's gate closure, which is why #13364's CI stayed green.Change
Each reader now calls the chain-derived accessor
v2.compiler.native_test_vocabularynative_test_file_refusal_fatal_reason(fr: refusal), with an explicit import. The four modules:v2.test.claim.namespace_xl0.let_match_early_return(named by the manager)v2.test.claim.namespace_xl0.return_tail_position(named by the manager)v2.test.claim.namespace_xl0.call_argument_value_resolve_refusal(found by the grep below)v2.test.claim.namespace_xl0.if_arm_and_statement_lowering_refusal(found by the grep below)Corpus-wide check (the floor won't report this)
Command:
Zero of the remaining hits read a
NativeTestFileRefusal:whole_tree_census_resolve_testandv2.compiler.compile(line ~4444) read the census group and member types, which carry their ownfatal_reason/head_reasonfields.native_lane_runner.rshit reads the host's own decoded structNativeFileRefusalObserved, which is filled from the chain.Direct evidence: every test fn of all four modules (the floor does not plan these modules)
claim_batch(built from this branch) was run locally at head 3375a50, once per module, over everytest fnthe module declares:Every module resolves (typechecks) and exits 0, with 70 / 70 PASS:
v2.test.claim.namespace_xl0.let_match_early_return: 18 PASS, 0 FAILa_let_match_with_one_binding_arm_and_returning_arms_is_acceptedthe_rest_after_a_let_match_is_read_and_refuses_unbound_at_its_atoma_returning_arm_operand_is_read_and_refuses_unbound_at_its_atoma_binder_free_binding_arm_value_is_read_and_refuses_unbound_at_its_atoma_let_match_in_the_rest_of_another_is_acceptedtwo_binding_arms_refuse_as_needing_a_join_pointa_let_match_outside_a_tail_spine_still_refuses_as_not_in_tail_positiona_return_inside_the_binding_arm_still_refuses_as_not_in_tail_positiona_let_match_in_a_fn_value_exits_only_the_fn_value_and_is_acceptedthe_rest_does_not_see_the_binding_arms_bindersa_bare_constructor_binding_arm_stays_a_constructor_patternan_arm_binder_hiding_an_outer_parameter_still_refusesa_nested_constructor_in_a_field_pattern_is_classified_by_resolvea_literal_binding_arm_is_acceptedthe_uri_path_segment_parser_is_admitted_by_body_loweringa_binding_arm_value_may_use_its_binders_and_is_acceptedthe_rest_after_a_let_match_appears_exactly_once_in_the_lowered_treeevery_returning_arm_of_a_let_match_keeps_its_operand_in_the_lowered_treev2.test.claim.namespace_xl0.return_tail_position: 17 PASS, 0 FAILa_return_inside_a_let_bound_if_refuses_rather_than_binding_its_operanda_return_followed_by_a_statement_refuses_as_not_in_tail_positiona_return_before_another_statement_in_a_fn_value_refusesan_else_less_if_that_falls_through_still_refuses_as_unloweredan_else_less_if_as_the_last_statement_still_refuses_as_unlowereda_guard_in_a_non_tail_spine_still_refuses_as_unlowereda_tail_return_of_a_fn_body_is_accepteda_tail_return_after_a_let_is_accepteda_tail_return_of_a_fn_value_block_body_is_accepteda_tail_return_operand_is_read_and_refuses_unbound_at_its_atoma_return_in_an_arm_of_a_tail_if_is_accepteda_guard_followed_by_statements_is_accepteda_guard_arm_return_operand_is_read_and_refuses_unbound_at_its_atomthe_statements_after_a_guard_are_read_and_refuse_unbound_at_their_atoma_return_in_an_arm_of_a_tail_match_is_accepteda_tail_match_arm_return_operand_is_read_and_refuses_unbound_at_its_atoma_return_in_an_arm_of_a_match_nested_in_a_tail_match_arm_is_acceptedv2.test.claim.namespace_xl0.call_argument_value_resolve_refusal: 21 PASS, 0 FAILa_named_list_argument_reaches_resolvea_positional_list_argument_reaches_resolvean_undeclared_name_in_a_nested_call_argument_refuses_at_resolve_at_its_atoma_list_inside_a_nested_call_argument_reaches_resolvean_undeclared_name_in_a_positional_nested_call_argument_refuses_at_resolve_at_its_atoman_undeclared_name_in_a_record_literal_argument_refuses_at_resolve_at_its_atoma_list_inside_a_record_literal_argument_reaches_resolvean_undeclared_name_in_a_parenthesised_argument_refuses_at_resolve_at_its_atomliteral_and_string_arguments_resolvea_nullary_call_argument_resolvesdeclared_names_inside_nested_call_and_record_arguments_resolvean_undeclared_plain_name_argument_refuses_at_resolve_at_its_atoman_undeclared_name_in_a_call_match_scrutinee_refuses_at_resolve_at_its_atoma_call_match_scrutinee_resolvesa_multi_line_call_match_scrutinee_resolvesa_match_with_a_call_scrutinee_nested_in_an_arm_resolvesan_undeclared_name_in_a_parenthesised_call_operand_refuses_at_resolve_at_its_atoma_parenthesised_call_operand_resolvesa_caret_symbol_operand_resolves_without_lookupan_as_cast_operand_resolvesan_else_less_if_guard_resolvesv2.test.claim.namespace_xl0.if_arm_and_statement_lowering_refusal: 14 PASS, 0 FAILa_call_argument_in_a_then_arm_refuses_at_resolve_at_its_atoma_call_argument_in_an_else_arm_refuses_at_resolve_at_its_atoma_call_argument_in_a_nested_if_arm_refuses_at_resolve_at_its_atoma_bare_name_in_an_if_arm_refuses_at_resolve_at_its_atoma_statement_followed_by_another_in_a_fn_body_refuses_at_normalizea_statement_followed_by_another_in_an_if_arm_refuses_at_normalizea_statement_after_a_let_followed_by_another_refuses_at_normalizea_literal_statement_followed_by_a_declared_name_refuses_at_normalizedeclared_call_arguments_in_if_arms_resolvedeclared_call_arguments_in_nested_if_arms_resolvea_let_block_in_an_if_arm_resolvesa_let_followed_by_its_body_resolvesa_match_in_an_if_arm_resolvesa_match_binder_used_in_a_nested_if_in_an_if_arm_resolvesThere are no failures at this head, so no merge-base comparison is needed. At the merge base (main after #13364) these four modules do not typecheck at all: they read the removed
fatal_reasonfield, so none of their claims reaches a verdict.🤖 Generated with Claude Code