Repository navigation
r2_origin: pin the minted fabric-workspace credentials - #13397
Merged
Merged
Conversation
From the federated mint runs 37291106411 (read) and 37292959180 (write): secret version 1 of
cloudflare-r2-workspace-{read,write}-token, access key ids = token ids from the receipts
(r2_s3_access_key_is_created_token_id_citation). fabric_workspace_standing is now
OriginCredentialPinned for both; witness asserts the exact pins. 32/32, 18/18, 8/8.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins the two credentials minted for the
fabric-workspaceR2 placement (#13161), so the workspace readers and writers stop refusing atgunbc.cloudflare.r2_originfabric_workspace_standing.r2_s3_access_key_is_created_token_id_citation)r2-workspace-object-read-mint-receipt)cloudflare-r2-workspace-read-tokenv1fabric_workspace_read_access_key_idr2-workspace-object-write-mint-receipt)cloudflare-r2-workspace-write-tokenv1fabric_workspace_write_access_key_idThe pins follow the durable origin's pattern (#11713):
OriginCredentialPinned { access_key_id, token_value: secret_ref_pin_version(fleet_secret_ref(id), version) }. As with those pins, the instrument that re-derives a token id islist_account_tokens_for_reconcile, and a rotation changes a credential's version and key id together. Access key ids are not secret.The bucket
gunbai-fabric-workspaceexists:r2_bucket_ensurerun 37294324885 reported 'fabric-workspace absent apply create ok (locationHint requested enam); readback converged'. The accessor cells are part of the 13 R2 custody cells granted bygcp-iam-converge(run 37288763345, #13298).Evidence:
r2_workspace_standing_pins_both_minted_credentials(renamed from the unminted assertion) checks both key ids, both secret names, both versions, and that the two key ids differ. claim_batch on BuildBuddy, full rosters: cloudflare_r2_origin_mint_run 32/32, cloudflare_r2_bucket_ensure 18/18, fabric_blob 8/8.Next: the If-Match race test against this bucket. It is what can cite
extdeps.cloudflare.r2r2_conditional_put_linearizability, which gates the workspace commit path.🤖 Generated with Claude Code