Skip to content

value_position_whole_read: read the domain binder through binder_node_parts (7 silent reds on main) #13394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gunbai-bot merged 1 commit into from
Oct 5, 2026
Merged

value_position_whole_read: read the domain binder through binder_node_parts (7 silent reds on main) #13394

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/v2/test/claim/namespace_xl0/value_position_whole_read_test.dag
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ import v2.std.compilers.body_lowering {
application_read
}
import v2.std.arrow_signature { ArrowParameterOrderAbsent, ArrowParameterOrderDeclared, ArrowParameterOrderMalformed, arrow_declared_parameter_order }
import v2.std.node_query { field_projection_optional, node_positional_child_targets }
import v2.std.node_query { binder_node_parts, field_projection_optional, node_positional_child_targets }
import v2.std.type_binder { type_param_names }
import v2.std.collection { list_at_optional }
import v2.extdeps.languages.dag { dag_language_model }
Expand Down Expand Up @@ -472,10 +472,14 @@ fn vpw_domain_binds(arrow: Node, binder: Symbol) -> Optional<Node> {
match list_at_optional(xs: node_positional_child_targets(node: arrow), index: 0) {
Present { value: domain } =>
match named_edge_target_lookup(children: domain.children, name: binder) {
Found { target: t } =>
match node_atom_identity_optional(node: t) {
Present { value: tv } =>
if vpw_symbol_in(xs: type_param_names(n: arrow), s: tv) { optional_present(value: t) } else { optional_absent() }
Found { target: binder_target } =>
match binder_node_parts(n: binder_target) {
Present { value: parts } =>
match node_atom_identity_optional(node: parts.type_node) {
Present { value: tv } =>
if vpw_symbol_in(xs: type_param_names(n: arrow), s: tv) { optional_present(value: parts.type_node) } else { optional_absent() }
Absent => optional_absent()
}
Absent => optional_absent()
}
_ => optional_absent()
Expand Down