Repository navigation
reference_conservation: the census names a normalize refusal's reason and locus - #13323
Merged
Merged
Conversation
… and locus A refused module reported a refused count and refusal-not-at-or-above per atom with no cause. The report now carries the fatal normalize diagnostic, its node locus resolved through the module's span index, and the summary line prints refusal=<stage>:<reason>@<locus> or refusal=none. RFM row census_counts_a_stage_refusal_without_naming_its_cause. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…verdict (review 76036) Delete the three local locus renderers and the local node-locus resolver; the carrier holds the fatal diagnostic and the text lens_verdict_diagnostic_located_text_in_spans renders with the module's span index. Fixture expectation is now '<reason> @ <file> bytes 47..54'. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Addressed review 76036: deleted conservation_refusal_locus_resolved / conservation_refusal_locus_text / conservation_refusal_extent_text. ReferenceConservationNormalizeRefusal is now { fatal: Diagnostic, located: String }, where located is v2.std.lens_verdict lens_verdict_diagnostic_located_text_in_spans(d: fatal, index: spans) (tokenize/parse arm uses the same door with span_index_empty()). Summary line ends |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XL-2 N7 follow-up to #13305 (observability gap, manager item 3).
Problem.
reference_conservation_census_for_pathsconsumed normalize's refusal diagnostics only as a cover, so a refused module printedrefused=Nandrefusal-not-at-or-aboveper atom with no reason or locus. That is why v2.compiler.service_realization's post-parse refusal looked causeless.Change.
ReferenceConservationReportcarriesnormalize_refusal(fatal reason + locus, node locus resolved to text through the module's span index). The summary line always printsrefusal=<stage>:<reason>@<locus>orrefusal=none. RFM rowcensus_counts_a_stage_refusal_without_naming_its_cause.Controls (fixture module that refuses at normalize, plus an accepting control), all 6 claims PASS on BuildBuddy via claim_batch:
No rows added to floor_cross_claim_pure_producers_warm.
The cause it would have printed (measured with a probe over main's file): on #13305's head normalize refused with
normalize_reason_post_normalize_not_well_formedat bytes 0..6 (the module keyword); on #13309's head and on main it accepts. Nothing to fix in service_realization.dag.🤖 Generated with Claude Code