Repository navigation
live_deploy oracle: the approval broker unit's expected bytes carry GUNBC_WORKSPACE_ROOT - #13250
Merged
Merged
Conversation
…UNBC_WORKSPACE_ROOT The emitter has written Environment=GUNBC_WORKSPACE_ROOT=<release dir> into the broker unit since #12011 (live_deploy.emit release_locus_workspace_root_environment; the seed refuses to run without it). The oracle string was authored in #12747/#12787 without that line, so the_approval_broker_unit_would_install_these_bytes has been red on main since it was written. Diagnosis by bright-hawk-257. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a claim that has been red on main since it was written:
live_deploy_unit_emission_oraclethe_approval_broker_unit_would_install_these_bytes. It also showed up as an unexplained red in the deployment-risk lane (#13130 / #13217).Cause (diagnosed by bright-hawk-257):
Environment=GUNBC_WORKSPACE_ROOT=<release dir>into the approval broker unit, betweenWorkingDirectoryandExecStart, since microVM slot controller on srv1: the unit execs run_controller as MainPID, the 28 GiB shakedown slot, the reservation-authorized planner arm, the controller's release locus #12011 (gunbc.live_deploy.emitrelease_locus_workspace_root_environment). The seed refuses to run without its workspace root, so the line is deliberate.Fix: add that one line to the expected bytes. The annotation above the claim now names it as part of the release locus.
The emission is correct and the oracle was wrong, so this changes the expectation, not the emitter. Remote
claim_batchverification of the claim is running.🤖 Generated with Claude Code