Skip to content

02_parse: read the entry production off the prepared grammar (~65k fixed eval steps per parse) #13244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gunbai-bot merged 2 commits into from
Oct 4, 2026
Merged

02_parse: read the entry production off the prepared grammar (~65k fixed eval steps per parse) #13244

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
900bb21
02_parse: read the entry production off the prepared grammar, not re-…
Oct 4, 2026
1b4eaf7
02_parse: name no transcribed measurement in the entry-production ann…
Oct 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 17 additions & 10 deletions src/v2/compiler/02_parse.dag
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5104,6 +5104,13 @@ fn parse_production_prepared_measured(
)
}

// THE ENTRY PRODUCTION IS READ OFF THE PREPARED GRAMMAR, never re-derived per parse: its lookup is
// the analysis's productions_by_name index and its prepared tree (choice plans, FIRST unions) is the
// analysis's prepared_exprs row, exactly as every nested nonterminal already reads it
// (parse_nonterminal_memoized). Routing the entry through parse_expr re-ran prepare_grammar_expr --
// choice-plan compilation plus the authored-choice overlap residue, which the parse then discarded --
// and an O(P) non-short-circuiting fold over every production, on EVERY parse, re-deriving a
// property of the grammar that prepare_grammar already computed once.
fn parse_production_prepared_measured_seeded(
tokens: List<Token>,
validated: ValidatedGrammarRoot,
Expand All @@ -5114,18 +5121,18 @@ fn parse_production_prepared_measured_seeded(
materialization: Materialization
) -> ParseProductionMeasured {
let root = validated.root
match grammar_lookup_production(root: root, name: production_name) {
let table = parse_table_for_stream_analyzed(
validated: validated,
analysis: analysis,
layout: layout,
all_tokens: tokens,
materialization: materialization
)
match grammar_lookup_production_indexed(table: table, name: production_name) {
Holds { value: production } =>
let prov = parse_prov_seeded(seed: seed)
let table = parse_table_for_stream_analyzed(
validated: validated,
analysis: analysis,
layout: layout,
all_tokens: tokens,
materialization: materialization
)
let parsed = parse_expr(
expr: production.expression,
let parsed = parse_expr_with_first(
expr: parse_table_prepared_expr(table: table, production: production),
tokens: tokens,
all_tokens: tokens,
root: root,
Expand Down