Repository navigation
HostIdentity moves to the leaf product.host_identity (stacked on #13175) - #13209
Merged
Merged
Conversation
added 4 commits
October 3, 2026 23:27
… LiveTreeDisposition in the github app registry witness
…ity; importers repointed
…ity; importers repointed
…ment_loop citation, to product.host_identity Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…712dcc + sweep); old stacked history superseded
…uthority (main_wet) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
briansrls
approved these changes
Oct 4, 2026
briansrls
left a comment
Contributor
There was a problem hiding this comment.
LAND on the rebuilt head. HostIdentity and host_identity_eq move as one authority to the leaf product.host_identity; product.placement_supply consumes them rather than retaining an alias, and the importer/DeclarationRef edits are mechanical. The generated-lane repair adds the one missed gunbc.generated_artifact importer and does not change the model. Exact-head CI has restarted and is still queued, so this approval records code readiness, not permission to bypass the required run.
gunbai-bot Bot
pushed a commit
that referenced
this pull request
Oct 4, 2026
…13209); this branch's imports name it Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
gunbai-bot Bot
pushed a commit
that referenced
this pull request
Oct 4, 2026
…3209) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
gunbai-bot Bot
pushed a commit
that referenced
this pull request
Oct 4, 2026
…tity (#13209) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HostIdentity moves to the leaf
product.host_identityTracked follow-up from #13175. Its trigger was #13145 (the wave-1C cut) merging. Stacked on #13175 (base branch
session/bright-hawk-257-host-identity); retarget tomainonce #13175 lands.type HostIdentity(a brandedNonEmptyStr) andhost_identity_eqwere declared inproduct.placement_supply. That module also importsextdeps.dhcp.v4 { MacAddress }, which reachesextdeps.dns.domain_name. So every module that only names a host (gunbc.fleet_host_identity,gunbc.fleet_posix_accounts,gunbc.fleet_lifecycle_observation, among others) imported DHCP and DNS.product.host_identity, which imports onlystd.types.product.placement_supplyimports both back for its own rows. The two sibling notes (physical_asset_identity_eq,site_identity_eq) now cite the new home.import product.placement_supply { … }naming either symbol is split mechanically; any other names stay (323 modules import the leaf). OneDeclarationRef(gunbc.doc_graph_roots) is repointed.Effect on the broker closure: none yet (192 → 192), and the 189 I predicted on #13175 was wrong. That figure assumed #13145 would remove the broker's only route to
product.placement_supply. It doesn't:gunbc.auth.approval_broker_serveitself importsextdeps.tailscale.serve { ServeStatusUnreadable }, andextdeps.tailscale.serve→product.network_topology→product.placement_supply(network_topologylegitimately usesPhysicalAssetIdentity). After this PR that is the only route, so cutting the broker's directtailscale.serveedge would dropplacement_supply,dhcp.v4anddns.domain_namefrom the broker closure. That edge is a separate question, raised with gentle-dove-36 rather than folded in here.Evidence (local,
gunbcrebuilt at this head):gunbc compile --target ruston the broker entry: 0 blocking, 199 files emitted (the whole closure resolves).product.placement_supplyresolves.test.claim.fleet.fleet_intent_network_witness_testfails resolve witheffect summary incomplete … product.network_topology.network_reachability … names no registry row, identically on main e624825 and at Fleet host identities move to the leaf gunbc.fleet_host_identity (broker closure 196 → 192) #13175's head. It is not from this PR.🤖 Generated with Claude Code