Repository navigation
Land the Bool de-fork stack (#12559 then #12583) - #13193
gunbai-bot[bot] wants to merge 1 commit into
Conversation
…_interpreter_seed_growth The follow-up named in #12567 (PR comment 5938185062) and #12559's body, due once #12846 landed: native_variant_reading, NativeVariantReading and InterpContext's variant_realization_refusal side-channel join the Nat row under the same lane and trigger, instead of minting a second row. eval_var, match_pattern and InterpError carry the matching edits and stay cited by their existing rows. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5a1addc3f9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| owning_dissolution_lane: "v1-hand-queue-drain" as RoadmapNodeId, | ||
| trigger: "Delete the eval_match refusal and the eval_expr_inner image arm when match and literal evaluation are realized by the self-emitted interpreter, which reads the same folded tree and has no constructor-versus-integer case to refuse. Equivalently, when the seed interpreter's pattern matcher returns a typed refusal instead of an Optional, so an unfolded constructor pattern over an integer is refused where it is matched rather than by a pre-check in eval_match. Rewording the refusal or widening its exempt constructor list does not dissolve this row. The exemption (kernel_raw_payload_constructor) is keyed on the pattern's parent carrier spelling, Optional or Witness, because the seed's MatchPattern carries no DeclarationRef (review 73985); a DeclarationRef on the pattern is the next rung for that key.", | ||
| current_boundary: "src/v1/stage0/src/v1_interpreter.rs eval_expr_inner, eval_match, eval_record_lit, match_pattern; src/v1/04_infer.dag ground_kernel_views; dag/gunbc/kernel_grounding_interpreter_seed_growth.dag", | ||
| trigger: "Delete the eval_match refusal and the eval_expr_inner image arm when match and literal evaluation are realized by the self-emitted interpreter, which reads the same folded tree and has no constructor-versus-integer case to refuse. Equivalently, when the seed interpreter's pattern matcher returns a typed refusal instead of an Optional, so an unfolded constructor pattern over an integer is refused where it is matched rather than by a pre-check in eval_match. Rewording the refusal or widening its exempt constructor list does not dissolve this row. The exemption (kernel_raw_payload_constructor) is keyed on the pattern's parent carrier spelling, Optional or Witness, because the seed's MatchPattern carries no DeclarationRef (review 73985); a DeclarationRef on the pattern is the next rung for that key. The Bool arms dissolve on the same trigger: a self-emitted interpreter reads the identity-stamped tree and needs no side-channel, and a match_pattern that returns a typed refusal retires variant_realization_refusal together with the eval_match pre-check.", |
There was a problem hiding this comment.
If the alternative trigger is reached by changing match_pattern to return a typed refusal while the seed interpreter remains, only variant_realization_refusal and the eval_match pre-check become obsolete; native_variant_reading and NativeVariantReading are still called by eval_var and match_pattern to interpret identity-stamped Bool arms. Saying that all Bool arms dissolve on this same trigger therefore permits retiring the justification while its two newly enrolled Rust declarations remain live. Give those declarations the later self-emitted-interpreter trigger, and treat the typed-matcher change as only the side-channel's trigger.
Useful? React with 👍 / 👎.
Auto-opened by session-dashboard for session
gentle-seal-218.Pushing to
seed-growth-booladvances this PR.Worker attestation
Before flipping this PR to ready for review, confirm each item:
npm test,cargo test) and the result.Closes #Ndirective.Summary
TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.
Test plan