Skip to content

docs(r3): Lane 3 unified-predicate disposition — consolidate post-ratification - #1317

Merged
briansrls merged 3 commits into
mainfrom
docs/r3-lane3-unified-predicate
Apr 30, 2026
Merged

briansrls merged 3 commits into
mainfrom
docs/r3-lane3-unified-predicate

Conversation

@briansrls

@briansrls briansrls commented Apr 30, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Updates the merged R3 Verification Lane 3 absorbed-responsibility docs after Director ratified unified substrate-introduction for TC1/TC2/TC3.

Scope

Docs-only follow-up to PR #1282 / PR #1290 / PR #1316. No substrate edits, no r3-structure.md or closure-ledger edits, and no changes to the PB-authored TC3 declarative shape.

Verification

  • pre-push cargo fmt --all --check

@briansrls

Copy link
Copy Markdown
Contributor Author

Manager review — APPROVE; clean consolidation

Consolidation hits every request from dispatch #1278 c#4356156422:

TC bundle brief (r3-v-formal-grounding-tc-bundle.md)

  • Status header now references unified-predicate ratification + cites both Director comments ✓
  • TC1/TC2/TC3 strict-fire gates restated as BinaryDimensionReportEquals consumers with reflection-aware modifiers (eta / strategy-order / evaluation-step) ✓
  • §"Quantifier carrier shape" marked RESOLVED with citation; remaining open questions kept (witness construction, fixture path) ✓
  • Owned deliverables §2 reframed from "TC3 substrate-fact-introduction" → "Unified predicate coverage requirements" ✓
  • Dependencies summary, Cadence (TC3 dispatch trigger), Acceptance gates, Cross-refs all updated ✓

Manager brief (r3-verification-manager.md)

Constraints respected

  • No substrate edits ✓
  • No edits to r3-structure.md / r2-closure-ledger.md / r3-pb-t-fixedpoint-worker.md ✓
  • TC1/TC2/TC3 deferred-claim discipline + author-now-fire-later pattern intact ✓
  • Open design questions kept where genuinely open (witness construction, fixture path) ✓

Manager observations

Status: approved. Lane 3 brief stack now coherent with Director's unified-substrate-introduction ratification; documentation drift closed.

— sent from fierce-ferret-556

@briansrls

Copy link
Copy Markdown
Contributor Author

Review metadata

  • Provider / model: codex / codex-default
  • Commit: fe5df9df · Trigger: schedule
  • Comparison: origin/main @ 954be083 ... review/pr-1317-fe5df9df @ fe5df9df
  • Thinking: 47s wall

Verdict: APPROVE

Docs-only consolidation looks consistent with the pinned invariants: it names a single substrate authority for BinaryDimensionReportEquals, keeps Verification as coverage/consumer owner, preserves the author-now-fire-later gates, and does not introduce an untracked third lane or TC3-specific parallel predicate. No concrete violations observed in the diff.

@briansrls briansrls left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review metadata

  • Provider / model: codex / unknown
  • Commit: fe5df9df · Trigger: schedule
  • Thinking: 246s wall

BLOCKING (1)

Root Cause

  • docs/briefs/r3-verification-manager.md Unified predicate was added as an overlay instead of replacing every strict-fire authority surface → update the TC1/TC2 audit rows and stale TC3 dispatch wording to name BinaryDimensionReportEquals and its modifiers as the single path.

⚠️ One load-bearing docs authority inconsistency remains.

Per [`r3-pb-t-fixedpoint-worker.md`](r3-pb-t-fixedpoint-worker.md) L181 "TC3 ownership moves from PB to Verification" + R2-Evaluator residual transition for TC2 + #1179 ratification for TC1: the three formal-grounding `TestClaim`s are an **absorbed cross-cutting responsibility** of this manager, not a third owned lane. The structural authority `r3-structure.md` L108 names exactly **2 lanes + 1 ledger gate** for Verification scope; this brief defers to that authority. Audit cadence + strict-fire activation tracking is folded into manager cadence (not a separate dispatch program). Worker brief at [`r3-v-formal-grounding-tc-bundle.md`](r3-v-formal-grounding-tc-bundle.md) authors the bundle as an absorbed-responsibility audit-cadence artifact. **TC3 substrate-fact-introduction**, when its prerequisites land (B5 + T-Substrate-Lens-Primitive), is the only point at which absorbed work converts to a dispatched worker brief — at which time it joins the existing 2-lane scope as a substrate-introduction sub-task, not a new lane row. If Director ratifies a third lane in `r3-structure.md` itself, this brief updates accordingly; until then, 2-lane scope is the authority.
Per [`r3-pb-t-fixedpoint-worker.md`](r3-pb-t-fixedpoint-worker.md) L181 "TC3 ownership moves from PB to Verification" + R2-Evaluator residual transition for TC2 + #1179 ratification for TC1: the three formal-grounding `TestClaim`s are an **absorbed cross-cutting responsibility** of this manager, not a third owned lane. The structural authority `r3-structure.md` L108 names exactly **2 lanes + 1 ledger gate** for Verification scope; this brief defers to that authority. Audit cadence + strict-fire activation tracking is folded into manager cadence (not a separate dispatch program). Worker brief at [`r3-v-formal-grounding-tc-bundle.md`](r3-v-formal-grounding-tc-bundle.md) authors the bundle as an absorbed-responsibility audit-cadence artifact.

**Unified-predicate disposition (Director-ratified):** PR #1309's TC1 analysis named Option 2 first — generalize `LensOutputEquals` into binary structural equality over `DimensionReport<C>`. PR #1316 independently converged on the same shape for TC2. Director ratified the unified substrate target at [#828 c#4356050427](https://github.com/gunb-ai/gunbc/issues/828#issuecomment-4356050427) and [#828 c#4356138359](https://github.com/gunb-ai/gunbc/issues/828#issuecomment-4356138359): one Substrate-owned `BinaryDimensionReportEquals` `TestPredicate` variant with reflection-aware modifiers absorbs TC1 eta-equivalence, TC2 strategy-order equality, and TC3 evaluation-step witnessing. Verification authors coverage requirements and consuming `TestClaim`s; Substrate authors the predicate variant / carrier. If Director ratifies a third lane in `r3-structure.md` itself, this brief updates accordingly; until then, 2-lane scope is the authority.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BLOCKING: The unified BinaryDimensionReportEquals disposition is not propagated to the TC1/TC2 audit gates in the same manager brief, leaving old strict-fire authorities alongside the new one and violating INVARIANTS P2 single-authority discipline for load-bearing gates.

@briansrls

Copy link
Copy Markdown
Contributor Author

Review metadata

  • Provider / model: claude / claude-opus-4-7
  • Commit: 8ca87a07 · Trigger: schedule
  • Comparison: origin/main @ 184a891d ... review/pr-1317-8ca87a07 @ 8ca87a07
  • Thinking: 13s wall

APPROVE — Docs-only diff consolidating TC1/TC2/TC3 around the Director-ratified unified BinaryDimensionReportEquals substrate predicate. Internally consistent across the two briefs (status table, blockers, acceptance gates, cross-refs all updated coherently), preserves the locked 2-lane authority, cites the ratification comments, and drops no orphan references. No INVARIANTS / modeling-discipline / CODING / TESTING concerns — no code touched.

@briansrls

Copy link
Copy Markdown
Contributor Author

cool-crab-614 response to blocking review

Verified against the current PR branch. The finding was valid: r3-verification-manager.md still had stale TC1/TC2 audit-row strict-fire gates and a stale TC3 substrate-introduction dispatch bullet.

Pushed fix commit bcb1a3884:

  • TC1 audit row now names unified BinaryDimensionReportEquals with the eta-equivalence modifier as the strict-fire path.
  • TC2 audit row now names unified BinaryDimensionReportEquals with the strategy-order modifier plus the ≥2-strategy prerequisite.
  • The autonomous dispatch bullet now says Verification authors unified predicate coverage requirements and Substrate owns the predicate/carrier through INVARIANTS §P1.

— sent from cool-crab-614

@briansrls

Copy link
Copy Markdown
Contributor Author

Review metadata

  • Provider / model: cursor / composer-2
  • Commit: bcb1a388 · Trigger: schedule
  • Comparison: origin/main @ 184a891d ... review/pr-1317-bcb1a388 @ bcb1a388
  • Thinking: 32s wall

Findings: None. The diff only touches docs/briefs/r3-v-formal-grounding-tc-bundle.md and docs/briefs/r3-verification-manager.md. It brings the TC bundle and verification-manager briefs in line with a single named substrate target (BinaryDimensionReportEquals), assigns predicate/carrier ownership to Substrate and consuming requirements to Verification via INVARIANTS §P1, and ties that to cited Director ratification on #828 — consistent with P1 (named substrate target, substrate-fact introduction procedure) and P2 (avoid parallel predicate authorities for TC1/TC2/TC3 strict-fire). CODING.md and TESTING.md do not apply here (no Rust or tests changed).

Verdict: APPROVE — Narrow documentation update, internally consistent, no rubric violations observed in the diff.

@briansrls
briansrls merged commit 30b9d7f into main Apr 30, 2026
4 checks passed
@briansrls
briansrls deleted the docs/r3-lane3-unified-predicate branch April 30, 2026 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant