Skip to content

Floor: upload the cross-claim demand census from the required floor job - #13031

Closed
gunbai-bot[bot] wants to merge 2 commits into
mainfrom
royal-deer-478/restore-floor-tsv-uploads
Closed

gunbai-bot[bot] wants to merge 2 commits into
mainfrom
royal-deer-478/restore-floor-tsv-uploads

Conversation

@gunbai-bot

@gunbai-bot gunbai-bot Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Part (b) of FLOOR REPAIR C3 (plan #13030): gunbc.floor_cost_distribution_instrument lost its inputs when the required floor moved into the job emitted by gunbc.compiler_gate_workflow, because the TSV uploads were authored only in gunbc.witness_floor_workflow's step list.

What this change is now

Main (#13227) has since restored the per-claim cost receipt upload through one bound function, required_floor_claim_cost_upload_bound_step. This PR is narrowed to what is still missing: the cross-claim demand census upload.

The earlier form of this PR bound all five TSV uploads through one list. That is dropped in favour of main's one-function-per-artifact pattern, so there is one way to bind a floor artifact.

Evidence

🤖 Generated with Claude Code

#11742 moved the floor into gunbc.compiler_gate_workflow and re-bound only the
measurement-receipt steps from gunbc.witness_floor_workflow; the five TSV uploads
(disposition, expected-red join, long-home agreement, claim cost, cross-claim
demand) were inline in witness_floor_bound_steps and were not carried, so
floor_cost_distribution_instrument lost its input with no step refusing.

The five rows are now one list, witness_floor_tsv_upload_bound_steps, bound by
both the witness floor and compiler_gate_floor_bound_steps, so a job cannot take
the receipt and drop the TSVs.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@gunbai-bot

gunbai-bot Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor Author

floor_cost_distribution_instrument is shown reading this PR's uploaded artifact.

This PR's run 37078324678 uploaded all five floor TSVs. The artifact list is required-floor-claim-cost, required-floor-cross-claim-demand, required-floor-disposition, expected-red-roster-join and long-home-storage-agreement, beside the receipt. The generated lane's drift gate passed on the hand-matched YAML.

The instrument was run on that artifact as follows:

  • gh run download 37078324678 -n required-floor-claim-cost -D /tmp/floor-cost/37078324678
  • tools.floor_cost_distribution_instrument floor_cost_distribution_report_for(root: "/tmp/floor-cost", run_ids: ["37078324678"], baseline: "37078324678", contended: "37078324678", repaired: [], order: [])
  • It was evaluated with gunbc run from a scratch entry. The source is unchanged.

What it established:

  • runs loaded 1, runs refused as observed 0, rows excluded ... right-censored 0.
  • The band histogram covers every executed row: 540 + 77 + 14 + 22 + 11 = 664. That equals the artifact's # summary executed=664, so the current-vintage header (cost_reading plus the per-kind columns) decoded with nothing refused.
  • The inflation percentiles here are self-paired (baseline = contended = one run), so they carry no information. Only consumption is being shown.

Not in this PR: the instrument's zero-argument entry still names ten runs that predate the per-kind columns, and its own header says they refuse. Re-pointing floor_cost_sampled_runs at current-vintage runs is a data edit for whoever re-runs the near-ceiling analysis. It needs a deliberate run pair, not this PR's run.

Main (#13227) restored the per-claim cost receipt upload in the required floor job through one
bound function. This change now adds only what is still missing: the cross-claim demand census
upload, bound the same way (required_floor_cross_claim_demand_upload_bound_step) in both floor
jobs, so gunbc.floor_cost_distribution_instrument has its second input.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@gunbai-bot gunbai-bot Bot changed the title Restore the floor's TSV artifact uploads on the fleet floor job Floor: upload the cross-claim demand census from the required floor job Oct 4, 2026
@gunbai-bot

gunbai-bot Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor Author

Closing, by sharp-raven-357's ruling (2026-10-04).

Part (b) of the brief, giving gunbc.floor_cost_distribution_instrument its input back, is met by main's #13227: that instrument reads only required_floor_claim_cost.tsv, and #13227 restored that upload through required_floor_claim_cost_upload_bound_step.

What this PR had narrowed to, the cross-claim demand census upload, has no executing consumer: its only readers are recipes in docs/plans/ and a merged plan. That is the DESIGN §3c dangling case, and §6 says an instrument is a named entry point, not an artifact scraped by hand. If a .dag instrument later needs the census, it adds the upload together with its reader in one PR; required_floor_cross_claim_demand_upload_bound_step on this branch is the shape to reuse.

— sent from royal-deer-478

@gunbai-bot gunbai-bot Bot closed this Oct 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants