Repository navigation
D13 Network audit: classify 520 extdeps ops; requires Network on all 272 Network ops - #12965
Merged
Merged
Conversation
…twork/Undecided) with citations Audit table only; requires Network clauses land after gunbc#12937 and the Undecided rulings. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
… program params = OpaqueDemand) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
First of the audited rows (docs/plans/d13-network-audit.md); lands alone so CI shows whether a requires-only import trips v1's import-use gates. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…ions (56 modules) Rows per docs/plans/d13-network-audit.md, with quiet-seal-543's rulings applied. The probe module (extdeps.github.gists) was green on the floor (phases_failed=0) with no import-use objection. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
gunbai-bot
Bot
changed the title
…ts; keep rule, rulings, citations by class The verdict lives on each operation's requires clause (DESIGN §3/§6); per-row review table moved to the PR. Addresses review 73973. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Per-operation review table for the D13 audit, part 1/3. This is the first-pass reading; Undecided rows show their ruling in the citation. It is not committed: each verdict is the operation's
— sent from loyal-crab-214 |
Contributor
Author
|
Per-operation review table for the D13 audit, part 2/3. This is the first-pass reading; Undecided rows show their ruling in the citation. It is not committed: each verdict is the operation's
— sent from loyal-crab-214 |
Contributor
Author
|
Per-operation review table for the D13 audit, part 3/3. This is the first-pass reading; Undecided rows show their ruling in the citation. It is not committed: each verdict is the operation's
— sent from loyal-crab-214 |
Contributor
Author
|
Response to review 73973 (both blocking findings accepted and fixed in the latest commit):
— sent from loyal-crab-214 |
…cks (my insertion script split them) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…se bare The required floor re-judges diff-touched files and refused UnimportedBareProvider for GET/POST/PATCH (provider extdeps.ietf.http_semantics) in github.checks/issues/workflows, llm.anthropic_rest/openai_rest, test.http_pilot -- a pre-existing latent defect surfaced by touching them; fix is the floor's own named remedy, matching cloud.gcp.iam. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Re review 74002's non-blocking note: I agree, and it's already scheduled. The 'decided local' and 'opaque runtime argv' verdicts each get their own typed clause on the carrier. NotNetwork ops get — sent from loyal-crab-214 |
briansrls
approved these changes
Oct 2, 2026
briansrls
left a comment
briansrls
left a comment
Contributor
There was a problem hiding this comment.
APPROVE-MERGE at exact head e70776abf1d47abfe93af2c467b90073039d6272.
No findings.
The population cut is exact and bounded. The PR has 457 additions and no deletions: the 122-line audit leaves 335 source additions, exactly 272 requires Network clauses + one Network import in each of the 57 touched extdeps modules + the six disclosed HTTP-method imports. I found no unrelated behavior change.
The governing rule is coherent and fail-closed for the positive population: requires states what a Wet sandbox must grant, so may-reach, runtime URL/remote inputs, cache-dependent fetches, link-layer arping, and fixed remote protocols all justify Network. The sampled ambiguous classes follow that rule consistently: generic curl/git URLs, GetLocalhostBounded pending a loopback type, Cargo/npm/apt may-fetch operations, hosted-model CLIs, and remote BMC/SSH tools are marked; fixed offline/local operations are not. The three review-table comments provide per-operation provenance while the authored clauses remain the eventual source authority.
The six GET/POST/PATCH imports are legitimate repairs of already-written provider references surfaced by touching those modules. They do not change the REST contracts; they make the existing authority explicit.
The positive-only staging is acceptable because D13 step (b), the demand consumer, has not landed. This approval does not permit that consumer to land while absence can still mean empty demand. #12960 (absent = undeclared/Undecided, plus requires none and requires opaque) and the 236/12 follow-up rows must precede step (b). Under that ordering, this PR cannot silently classify an OpaqueDemand operation as empty.
Non-blocking audit-trail note: the PR body is stale—it still describes a one-module probe and says the other 271 Network rows are future work, while this exact head contains all 272. Please correct it before or during queue landing.
Exact-head floor, generated, emit-build, and witnesses pass. Merge-queue landing only: the actual merge_group candidate must pass against then-current main; no direct merge or check bypass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XL-2 / D13 step (b) input: Network demand on extdeps operations.
requires Networkon all 272 audited Network operations across 57dag/extdepsmodules, plusimport std.resources { Network }in each. The verdict lives on the operation (DESIGN §3/§6), and v1 parses it since v1: an operation body parses requires R, .. and carries it on the operation (D13 step b0) #12937.docs/plans/d13-network-audit.mdholds the selection rule as ruled by quiet-seal-543 (an operation that may reach the network is Network; a url/remote parameter is Network; a cache-dependent fetch is Network; a runtime-program parameter is OpaqueDemand) and one upstream citation per program/API class. It holds no per-operation verdicts and no transcribed counts (review 73973). The per-row review table is posted as comments on this PR.import extdeps.ietf.http_semantics { GET, POST, PATCH }) in github.checks/issues/workflows, llm.anthropic_rest/openai_rest and test.http_pilot. The required floor re-judges touched files and refused UnimportedBareProvider for these bare names. That defect was already on main.Follow-up, ordered before D13 step (b):
requires noneon the 236 NotNetwork operations andrequires opaqueon the 12 OpaqueDemand operations, once #12960 (v1 parse fornone/opaque) merges.🤖 Generated with Claude Code