Repository navigation
Required floor reports the eval-frame call memo's process-wide hits and misses - #12933
Merged
Merged
Conversation
…nd misses Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An instrument for the follow-up PR that changes the eval-frame call memo's key. That change must be judged on the FULL floor (deep-deer-663's parent, 2026-10-01), and the floor had no reading of this memo:
eval_call_memo_counters) die with each context.release_process_caches_at_exitdoc.Seed admission receipt: hand-written v1 seed Rust, admitted under
gunbc.v1_maintenance_standingv1_seed_standing(DESIGN §3 purpose test). It serves the v2 self-host program: it is the reading by which the eval-memo keying change (#12934) is judged on the full floor. It adds observability only, with no gate and no new growth surface.Change
eval_call_memo_gethit,eval_call_memo_putmiss), so the two cannot disagree about what a hit is.claim_executorprintsrequired-floor: eval_call_memo hits=<h> misses=<m>beside the existingcompile_dag_rust_emit_check_memoandcompile_dag_diagnostic_census_memoreceipts, one line each, as those are.This PR's own CI floor run is the BEFORE reading for the memo-key PR. Both runs report through this one instrument, so the numbers are cited from the runs, never transcribed (DESIGN §6).
Evidence:
cargo clippy -p v1-compiler --all-targets -- -D warningsis clean (remote).🤖 Generated with Claude Code