Skip to content

product_introduction census: an identity join over named Conjs, not a count (red since #12766) - #12932

Merged
briansrls merged 11 commits into
mainfrom
session/calm-hawk-793-census
Oct 2, 2026
Merged

briansrls merged 11 commits into
mainfrom
session/calm-hawk-793-census

Conversation

@gunbai-bot

@gunbai-bot gunbai-bot Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

v2.test.execution.infer_product_introduction.product_introduction_derives_fully_evidenced_products_holds was a silent red on main, counted on #12860 under calm-hawk-793.

Bisected (BuildBuddy, path-restricted to src/v2/{compiler,std,extdeps} and dag/std, from 1375c80 to main): the first bad commit is d5dc100, #12766 ("named-fn parameter references as path-keyed references; infer grounds them through the index"). That change is deliberate. Each named-fn parameter reference became a path-keyed reference carrier, a Conj under <parameter-reference>, so the specimen body x + y now carries two more products. Both derive.

Not a literal bump (lane-manager direction; DESIGN §5: "completeness is an identity join, not a count"). The claim read conjs == 4. It now names every Conj infer is asked to derive: it walks node_inferred_subtree_nodes, the existing authority, so no second set of skip rules exists. Each Conj is named by its children, meaning each child edge's label plus the last atom that child's subtree carries, because a parameter reference's path ends at the parameter it names. The claim requires exactly this named list, in walk order, with each derived:

[grammar_production_identity_node_projection=dag_surface_module][grammar_production_captured_node_projection=y]
[add_probe=y]
[grammar_production_identity_node_projection=namespace_graft_module_body][add=y]
[x=dag_binding_type_int][y=dag_binding_type_int]
[<parameter-reference>=x]
[<parameter-reference>=y]

A non-derived Conj appears as !name, so it can't match. The single-Arrow assertion is unchanged.

Executed green on BuildBuddy: this claim, plus product_introduction_composed_evidence_carries_child_groundings_holds (control). The identity leaves the #12860 amendment, and the projection is regenerated.

🤖 Generated with Claude Code

Brian Searls and others added 6 commits October 1, 2026 16:56
… count (red since #12766, bisected)

The claim read conjs == 4 and went red at #12766, which made each
named-fn parameter reference a path-keyed reference carrier: a Conj
under <parameter-reference>, so x + y carries two more products. The
census now names every Conj infer is asked to derive by its children
(edge label and the last atom the child subtree carries) and requires
exactly that named list, each derived (DESIGN 5: completeness is an
identity join, not a count).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…ts_holds leaves

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…-census

# Conflicts:
#	dag/gunbc/rung_drop_amendment/v2_test_family_reds_measured_outside_the_gate.dag
#	docs/design-rung-drops.md
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@briansrls
briansrls added this pull request to the merge queue Oct 1, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Oct 1, 2026
Brian Searls and others added 5 commits October 1, 2026 23:31
…-census

# Conflicts:
#	dag/gunbc/rung_drop_amendment/v2_test_family_reds_measured_outside_the_gate.dag
#	docs/design-rung-drops.md
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
… added

#12923 (a binder's target is a binder node) put each parameter's type
under a <binder-type> Conj, so the specimen carries two more products.
The identity join named the change instead of absorbing it; both are
named and required derived.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…-census

# Conflicts:
#	dag/gunbc/rung_drop_amendment/v2_test_family_reds_measured_outside_the_gate.dag
#	docs/design-rung-drops.md
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@briansrls
briansrls added this pull request to the merge queue Oct 2, 2026
Merged via the queue into main with commit 080463f Oct 2, 2026
4 checks passed
@briansrls
briansrls deleted the session/calm-hawk-793-census branch October 2, 2026 04:12
gunbai-bot Bot pushed a commit that referenced this pull request Oct 2, 2026
…nfer's string-literal payload read and the product_introduction census edge name read Authored, with an explicit structural arm

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant