Repository navigation
XL-2 carrier: record lowering fixes since #12584; add ServiceModuleLowering - #12793
Conversation
…wering Caret and ElseLessIf (guard) move to DELIVERED on their RFM rows' own trigger receipts (#12420 aa3b461; #12713 2e95e66). OptionalAccessor and LoweringOccurrenceProjection stay OUTSTANDING with the since-landed work recorded (#12598, #12757, #12615, #12725, #12754). Wildcard notes the distinct lowered form (#12597) with its RFM still open. New OUTSTANDING arm ServiceModuleLowering tracked by service_interface_member_has_no_carrier. Partition witness: 24 arms, 18 delivered / 6 outstanding; XL-2 NotDerivable. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…RFM rows; partition 20/4 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
briansrls
left a comment
There was a problem hiding this comment.
HOLD / REQUEST_CHANGES at exact head 45d33bb.
[P1] ListLiteralElementVisibility is already delivered, so the proposed 20-delivered / 4-outstanding partition and the P5 roster derived from it are wrong.
The landed receipt is gunbc#12208, merge 575fc486add332a5f5cce866a9338520c9192361, which is an ancestor of this PR's base. Its exact contract is the capability this arm names: one body_lower_list_literal producer reached from body_lower_primary_expr through the shared value reader on call-argument, data-initializer, let-value, operand and scrutinee routes; every element lowers whole, and an unreadable element refuses located. That implementation is present at this exact head. The canonical RFM list_literal_has_no_lowered_form explicitly records CLIMBED BY gunbc#12208, with production-route shape, resolve and reference-conservation evidence.
The carrier instead follows the stale duplicate RFM list_literal_elements_dropped_at_v2_body_lowering, whose receipts still claim body_lower_primary_expr answers [a] with [ and that no fix has merged. That contradicts both the live compiler and the canonical RFM. It also leaves the CompoundCallArgumentValueLowering qualification falsely saying a list-valued argument still refuses at the list.
Bounded correction:
- make
ListLiteralElementVisibilityPrerequisiteDeliveredwith gunbc#12208 /575fc486adand qualification matching the canonical RFM; - change the partition and witness to 24 = 21 delivered / 3 outstanding (
OptionalAccessorLocatedRefusal,LoweringOccurrenceProjection,ServiceModuleLowering), and change the XL-2 NotDerivable control's delivered count to 21; - remove the list-literal row from
xl2_prerequisites_outstanding(), which removes its spurious rehearsal/P5 cause; - reconcile the two list-literal RFMs, preferably deleting or retiring the stale duplicate rather than leaving two contradictory authorities; and correct the stale compound-call qualification.
The other delivered flips, residue qualifications, three genuinely outstanding arms, new service-module arm, derived rehearsal wiring, unchanged nesting ruling and exact-head checks otherwise look coherent. Return with the corrected exact head for merge-queue-only review; require the actual merge_group candidate to pass, with no direct merge or check bypass.
… duplicate RFM; partition 21/3 Addresses GitHub review 5369451225. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
briansrls
left a comment
There was a problem hiding this comment.
APPROVE-MERGE at exact head ab71a1b. This supersedes CHANGES_REQUESTED review 5369451225.
The blocker is resolved: ListLiteralElementVisibility is delivered by gunbc#12208 / 575fc48 with the canonical list_literal_has_no_lowered_form CLIMBED receipt and the discriminating list-literal truncation owner. The stale duplicate RFM is deleted, its remaining prose citation is repointed, and CompoundCallArgumentValueLowering no longer claims list/lambda/caret values remain refused.
The carrier and witness now agree on 24 prerequisites = 21 delivered / 3 outstanding: OptionalAccessorLocatedRefusal, LoweringOccurrenceProjection, and ServiceModuleLowering. The NotDerivable control derives 21 delivered. The rehearsal/P5 refusal roster remains derived from xl2_prerequisites_outstanding(), so moving ListLiteral to Delivered removes its cause without a second roster edit. Current main is merged.
No findings. Merge queue only: require all exact-head checks and the actual merge_group candidate to pass against then-current main; no direct merge or check bypass. A later #12780 carrier update is a separate post-landing delta and is not a condition on this exact head.
XL-2 carrier update (
gunbc.compiler_frontend_program_statusxl2_prerequisite_standing, its witness; the P5 rehearsal roster is derived fromxl2_prerequisites_outstanding, so it keeps one cause per outstanding arm by construction).Every SHA cited was checked as an ancestor of main.
caret_symbol_has_no_lowered_formrecords its trigger REACHED by MQ-1 PR-2. The #12617 handoff (39a0093) is cited too. The literal's type is not claimed.service_interface_member_has_no_carrier. Refusal at normalize (service_realization_unreachable) keeps these modules' references out of the census. Trigger: a typed operation-modifier and io wire-key/default carrier. No owner today.Also DELIVERED on their RFM rows' own receipts (at the parent's request): AsCastOperandLowering #12315 696a77d (trigger MET; refinement-cast residue on infer stays refused, typed), LambdaArgumentValueLowering #12210 c2c064f (row records CLIMBED; generic-Arrow emission is residue outside the class).
ListLiteralElementVisibility is DELIVERED by #12208 575fc48 on the canonical RFM
list_literal_has_no_lowered_form(CLIMBED); the stale duplicate RFMlist_literal_elements_dropped_at_v2_body_loweringis deleted (review 5369451225).Partition: 24 arms, 21 delivered and 3 outstanding (OptionalAccessorLocatedRefusal, LoweringOccurrenceProjection, ServiceModuleLowering). XL-2 stays NotDerivable. The nesting-ruling wording is untouched.
🤖 Generated with Claude Code