Repository navigation
NFR: enumerate the two E0004-blocked wildcards now that #12742 landed - #12764
Closed
gunbai-bot[bot] wants to merge 3 commits into
Closed
gunbai-bot[bot] wants to merge 3 commits into
gunbai-bot[bot] wants to merge 3 commits into
Conversation
grammar_tokens_fold_list_targets_into (v2.compiler.target_serialize) and concrete_syntax_token_node_targets_into (v2.std.compilers.target_model) are tail-recursive walks; enumerating their NodeKind wildcard used to fail emit-build with E0004, because emit_rust_tco_match rendered nested Rc arms as guards. #12742 routes the tail-call lowering through the #8570 Rc arm grouping, so both are enumerated directly: every non-Conj arm answers the same one-line refusal the wildcard did. No delegation workaround, no behavior change. emit-build on this PR is the check that the emitted Rust is exhaustive. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…d emit-build evidence The row held rung 1 because its discriminating control (the stage0 fixture tco_rc_grouped_match_emitted_rust) does not execute in required CI. Its trigger's other arm -- an enumerated nested arm set inside a tail-recursive walk that emits and builds -- has now run on the merge path: this PR's two sites build green in the required emit-build lane (run 36696087113, job 109824277149, head e065e20). Ceiling stays 3. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Consolidated into integration PR #12951 at the operator's request; this branch is merged there unchanged in its own merge commit. Closing here; the branch is kept. — sent from deep-ferret-305 |
github-merge-queue
Bot
removed this pull request from the merge queue due to a manual request
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the typed non-fold-residue burn-down (#12610) and the E0004 emitter fix (#12742, now on main).
Two sites were reverted to their wildcards during the burn-down. Enumerating them made emit-build fail with E0004:
emit_rust_tco_matchrendered nestedRcarms as match guards, and rustc cannot count guards toward exhaustiveness. #12742 routes the tail-call lowering through the #8570 Rc arm grouping. With that fix in, both sites are enumerated directly:v2.compiler.target_serializegrammar_tokens_fold_list_targets_into(reverted in NFR burn-down: src/v2/compiler — translate-serialize-lowering (enumerate 33 typed-census wildcards) #12667)v2.std.compilers.target_modelconcrete_syntax_token_node_targets_into(reverted in NFR burn-down: src/v2/std (target-model) — enumerate closed-coproduct wildcard arms #12671)Every non-
ConjNodeKindarm answers the same one-line refusal the wildcard did. There is no delegation workaround and no change in behavior. emit-build on this PR is the proof: the floor does not exercise the emitted Rust, and emit-build is exactly where E0004 appeared.The third blocked site (
rust_refusing_int_operator_helper, a warnings regression rather than E0004) is not included. Whether #12742 covers it is still open with the emitter lane.🤖 Generated with Claude Code