Repository navigation
Enumerate BinOp arms in rust_refusing_int_operator_helper (NFR burn-down) - #12733
Merged
Merged
Conversation
…own; 52-warning report not reproduced) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the
_wildcard inextdeps.languages.rust.emitrust_refusing_int_operator_helperwith one arm per remainingstd.syntaxBinOpvariant (Eq…NullCoalesce→none). The seed mirror is regenerated locally.Why this was reverted before, and why it can land now. An NFR burn-down run reported that this enumeration raised the
//gunbc/instruments:v2-native-cliemitted-crate warning_count from 0 to 52. Suspected cause: nullary variant patterns emitted as bare identifiers, which Rust binds as catch-all variables. I could not reproduce this on main f006fbe, with the site enumerated:gunbc test //gunbc/instruments:v2-native-cli(local):RUSTFLAGS="-D warnings" … exit_status=0 warning_count=0. The door and refusal controls pass.BinOp::Add => …, …,BinOp::NullCoalesce => std::option::Option::None).BinOpvariants also renders qualified.The emitter's bare-name fallback (
rust_variant_path_opt, Absent arm) is still a writable widening arm. It becomes a refusal in a separate PR, which also files the RFM row.Regen:
claim_executor --regen-round-costrun locally (ulimit -v 24G,-j4,CTRL_BUILD_MODE=local, privateCARGO_TARGET_DIR). Round 1 changedextdeps_languages_rust_emit.rsand rebuilt 4 packages. Round 2:rebuild_packages=0. Only the installed mirror is committed.🤖 Generated with Claude Code