Repository navigation
bmc_virtual_media: dissolve srv4 nbd argv command string rendering into typed ArgvCommands - #12728
Closed
gunbai-bot[bot] wants to merge 1 commit into
Closed
gunbai-bot[bot] wants to merge 1 commit into
gunbai-bot[bot] wants to merge 1 commit into
Conversation
…to typed ArgvCommands
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this change does
Dissolves shell string rendering of NBD client and server commands in
dag/gunbc/bmc/bmc_virtual_media.dagadjacent to PR #12579.Replaces string renderers with typed
ArgvCommandsurfaces:srv4_nbd_server_command_text()->srv4_nbd_server_command() -> ArgvCommandsrv4_nbd_client_attach_command_text()->srv4_nbd_client_attach_command() -> ArgvCommandsrv4_nbd_client_disconnect_command() -> ArgvCommandfor planned lifecycle teardown.shell_command_renderimport and calls fromgunbc.bmc_virtual_media.Migrates BMC Virtual Media Witness assertions:
dag/test/claim/bmc/bmc_virtual_media_witness_test.dag, replaces string contains / shell rendering matching with assertions on typed argv components: program identity (nbd_client_program(),nbd_server_program()), word counts, arguments length, flags (-N,-d,-C), and parameters.