Repository navigation
NFR burn-down: enumerate closed-coproduct wildcard arms in dag/gunbc/machine_intake - #12670
Merged
Merged
Conversation
…machine_intake Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…duct; tail call stays in the loop Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Three enumerated matches repeated one long result per variant: detach_verdict's still-presenting DetachNotEstablished (6x), readiness_wait_outcome's MegaRacReadinessRefused / MegaRacMediaStateUnestablished records (8x / 2x), and presentation_still_served's PresentationNoLongerReady (5x). Each is now bound once with a let beside its match and named by the arms, so the reason text and record fields have one spelling. Pure data, same values, no behavior change. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
briansrls
approved these changes
Sep 29, 2026
briansrls
left a comment
briansrls
left a comment
Contributor
There was a problem hiding this comment.
APPROVE at 81e330f. The changes are exhaustive, body-identical replacements over Optional and the named closed coproducts; I found no semantic change. A fresh CI run is currently in progress, so landing remains conditional on that run going green.
# Conflicts: # dag/gunbc/machine_intake/mtcollins1_boot_run.dag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typed NFR census (artifact/nfr-typed-census-2a1dd41, checker #12610) burn-down for
dag/gunbc/machine_intake/. Mechanical: each_ =>over a closed coproduct becomes the explicit remaining variants, each arm carrying the wildcard's identical body. No roster rows added (kept sites are handed to zesty-owl-698 with per-site reason + dissolution for the joint landing on #12610). Compile verification rides the floor CI on this PR.🤖 Generated with Claude Code