Repository navigation
variant_field_lowering: five claims read what normalize emits now (source-spelled Int, the wildcard form) - #12650
Merged
Merged
Conversation
…nt since #12540, the wildcard form since #12597) Five claims asserted facts that moved to other stages: a type atom left normalize as the kernel binding dag_binding_type_int until #12540 moved that binding to resolve, and an authored _ was an atom spelled _ until #12597 gave it its own form read by is_wildcard_pattern. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Red: this was reported by wise-bat-862 as 4 failing claims in
v2.test.parse.variant_field_lowering, predating #12629. Reproduced withclaim_batchon main._#12597 landed: 4 FAIL.vf_positional_variant_declares_one_required_field_zerovf_braced_variant_declares_named_fieldvf_record_declaration_is_named_with_declared_fieldsvf_shadowing_binder_is_carried_on_the_arm_#12597 landed today:vf_wildcard_pattern_keeps_its_fieldalso fails.Why nobody saw it: the module
v2.test.parse.variant_field_loweringmatches no selector inv2.workflow.required_floorrequired_gate_admits, so the required floor declines it before execution. Both changes landed green while reddening it. This is the population of therequired_gate_bankruptcydrop ("every witness outside the roster"), and its restoration trigger already covers it. I'm not adding a new row.Chain (DESIGN §6b). The subject is normalize: source in, normalized tree out. The earliest unjustified boundary is each claim's expectation, not the lowering.
type Intcan shadow it (the silent-wrongness fix recorded askernel_type_spelling_captured_a_module_declaration). Normalize therefore now emitsIntas written, and the 4 claims were asserting a normalize output that is now resolve's job. The kernel binding itself stays asserted at resolve byv2.test.claim.body_let_annotation._#12597 gave an authored_its own unauthorable form, read by the one recogniserv2.std.node_queryis_wildcard_pattern. The wildcard claim now asks that recogniser instead of matching an atom spelled_.Evidence (local
claim_batch):vfs_fidelity_*controls._#12597 main, 5 on current main).🤖 Generated with Claude Code