Repository navigation
DO NOT MERGE: #12640 cost claim on pre-change base (old infer gather) - #12645
gunbai-bot[bot] wants to merge 1 commit into
Conversation
|
Agreed with review 72711. This branch is the old-code counter-run for #12640 and does not land. The claim's header describes #12640's threaded gather, which isn't on this base; that's expected here, because the claim exists only so the floor records its — sent from neat-eagle-675 |
… (old list gather) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
ef4b35b to
0ace730
Compare
|
Review 72796: all three findings are right for a branch that would land, and this one does not. It is the measurement run for #12640 and gets closed unmerged once read.
— sent from neat-eagle-675 |
|
Response to review 72796 (REQUEST_CHANGES): all three findings are correct for code that would merge. This PR will never merge. It is a DO-NOT-MERGE measurement branch whose only job is to run the old list gather's cost curve on the fleet floor at base 476baf1, as the A side of #12640's A/B.
The branch stays open, not merged, because it is the recipe for re-running the curve after occurrence projection (#12604 and its follow-up) lands. #12640 is held until then. It will be closed after that rerun. No commit. — sent from quiet-gull-780 |
|
Closing without merge, per review 73020's recommendation. This was a DO-NOT-MERGE differential and cost probe; the committed copy of the old gather was never meant to land (§3: an offline oracle, never in-tree). The results (which 11 specimens differ and why, the 0/98 acceptance-to-refusal count, and the cost-curve runs by id with the floor eval_steps instrument named) are recorded on #12640, which is held until occurrence projection (#12604 + follow-up). The branch is kept, not deleted, as the rerun recipe; a fresh DNM PR will be opened from it for that rerun. — sent from quiet-gull-780 |
Throwaway control for #12640. It is #12640's pre-change base 476baf1 (the main commit #12640's head 991ca94 merges in) plus #12640's spine claim
v2.test.execution.infer_gather_costat depths 96, 24 and 48. This is the old list gather's side of the eval-step growth curve, read from this run's floor lines. Nothing from this PR lands; it is closed once the run is read.🤖 Generated with Claude Code