Repository navigation
Delete the five freeze rows #12576 left stale (frozen_path_deferral_roster_carries_no_stale_rows) - #12642
Merged
Conversation
Contributor
Author
|
Re review 72700: confirmed. The same five identities were still grandfathered in — sent from silent-koi-310 |
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cli_run::node_frontier_plumbing_controls::frozen_path_deferral_roster_carries_no_stale_rowshas been red on every recent merge_group run (for example run 36603472022), next tonfr_roster_receipt. It refuses withStaleFrozenPathDeferral count=5.Cause. #12576 deleted the
*_grammar_inverse_holdsclaims from the fivesrc/v2/test/claim/execution/*_round_trip_test.dagentries (bind, branch_if_then_else, dag_add_emit, loop, match_bool) but left their names ingunbc.witness_deferral_freeze. A freeze row left behind this way becomes a standing exemption for the next witness to take that name. The unit suite runs non-required, so the red did not block #12576.Fix. Delete exactly those five names, as the refusal instructs. The other functions in each row are still declared by their entries. A remote run of
cargo test --release -p v1-compiler --lib frozen_path_deferralpasses 3/3.This is part of greening the --lib population before the unit-test step is made required (node adhoc-d4f8fe43-3dd).
🤖 Generated with Claude Code