Repository navigation
Census: runner_browser_toolchain_converge_ci_wet does not select (unblocks every fleet plan) - #12618
Merged
Merged
Conversation
…ry fleet plan refused CensusProtocolUnbound) gunbc#12500's census row declared selects AND observes, which admit_protocol_phases refuses as SelectionLeakedIntoObservation, so bind_canonical_protocol answered CensusProtocolUnbound and gunbc.fleet_converge_plan_cli refused every plan (runs 36562381449, 36563688759). The mode selects no realization: it admits a host into the pool derived from the floor job's labels (admits), observes superseded trees, reads back and checks readiness. Selection is std.decision's row alone. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every fleet-converge plan on main refuses with
CanonicalProtocolRefused — gunbc.host_convergence_protocol bind_canonical_protocol answered CensusProtocolUnbound. Examples are the srv1 plans in runs 36562381449 and 36563688759 ate0d0e01efb. This blocks every fleet deploy, including taking #12482 live.Cause. #12500 added a
gunbc.host_convergence_censusrow forgunbc.runner_browser_toolchainrunner_browser_toolchain_converge_ci_wetwithprotocol_phases(true, true, …), which declares both selects and observes.admit_protocol_phasesrefuses that combination asSelectionLeakedIntoObservation, sobind_census_protocol_phasesanswersCensusSelectionLeakedfor that row, andfleet_converge_plan_clirefuses to plan. A probe on main confirmed that exact row.Fix. Set
selectsto false. The mode chooses no realization:runs-onlabels (runner_browser_toolchain_host_admission);admitswas already declared.Selection belongs to
std.decision's row alone, which is the only other row declaringselects. The rest of #12500 is untouched.Evidence, executed locally on main plus this fix:
bind_census_protocol_phases→CensusPhasesBoundandcanonical_protocol_gate→CanonicalProtocolAdmitted. On main without the fix it reportedCensusSelectionLeakedat this row.test.claim.host_convergence_protocol_witnesscanonical_protocol_binds_with_apply_awaitingandproduction_gate_admits_the_canonical_protocolboth returntrue.witty-crane-254 (#12500's owner) is asked to review.
🤖 Generated with Claude Code