Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions src/v2/test/required_floor_gate_selector_test.dag
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,10 @@ data live_tree_disposition: LiveTreeDisposition = SubstrateInputsOnly

// THE GATE'S TWO SELECTOR KINDS, EXERCISED THROUGH THE ACTUAL ADMISSION DECISION AND NOT A
// STRING HELPER (review on gunbc#11708, RF-1). `required_floor_site_disposition` is the fold
// every discovered site takes, so what these rows establish is the disposition a site gets --
// and it is in the `v2.test.` family, so it executes on the required floor rather than being
// counted outside it, which is where the first draft of these rows would have sat
// (`test.claim.discovery_census_witness` matches no gate row: its roster row spells
// `..._witness_test`, a fourth instance of the class this module tests).
// every discovered site takes, so what these rows establish is the disposition a site gets.
// The broad `v2.test.` family these rows once relied on was withdrawn from
// `v2.workflow.required_floor` `required_gate_prefixes`, so every fixture below names a row the
// CURRENT gate carries -- a row these claims name going away turns them red rather than green.
fn site_is_planned(module_path: String) -> Bool {
match required_floor_site_disposition(
module_path: module_path,
Expand Down Expand Up @@ -57,12 +56,12 @@ test fn an_authored_module_row_does_not_admit_its_suffix_neighbour() -> Bool {
&& site_is_planned(module_path: "test.claim.runner_capacity_plan_witness.child")
}

// THE FAMILY RULE IS UNCHANGED BESIDE IT: a member of `test.claim.namespace_` -- a row that is
// deliberately not a segment -- is still admitted textually, so the authored-module kind was
// added without narrowing the prefix kind.
// THE FAMILY RULE IS UNCHANGED BESIDE IT: members of `test.claim.namespace_` and
// `test.claim.infer_` -- rows that are deliberately not segments -- are still admitted
// textually, so the authored-module kind was added without narrowing the prefix kind.
test fn a_family_row_still_admits_its_members_textually() -> Bool {
site_is_planned(module_path: "test.claim.namespace_resolution_witness")
&& site_is_planned(module_path: "v2.test.claim.ordinary_witness")
&& site_is_planned(module_path: "test.claim.infer_ordinary_witness")
}

// WHICH KIND ADMITTED A MODULE IS REPORTED, not collapsed into a Bool: the match names the
Expand All @@ -76,12 +75,12 @@ test fn the_match_names_the_kind_that_admitted() -> Bool {
GateModuleFamily { prefix: _ } => false
}
}
&& match first_required_gate_match(module_path: "v2.test.claim.ordinary_witness", selectors: required_gate_selectors()) {
&& match first_required_gate_match(module_path: "test.claim.namespace_resolution_witness", selectors: required_gate_selectors()) {
GateUnmatched => false
GateMatched { selector: s } =>
match s {
GateAuthoredModule { module_path: _ } => false
GateModuleFamily { prefix: p } => p == "v2.test."
GateModuleFamily { prefix: p } => p == "test.claim.namespace_"
}
}
}