Repository navigation
Conversation
…alue Two local-repo wet witnesses read the runner's own hostname and asserted the refusal a host with no dashboard instance produces. The CI runners include srv1, a declared dashboard host, where the lookup resolves and the claim failed; on srv3/srv4 it passed. The verdict depended on which runner took the job, not on the change under test. Both claims now supply the executor (under the RFC 2606 reserved `.invalid` TLD, so no declared instance can answer for it) and the instant, and live in their hermetic sibling files. They still execute the real read route -- current_pair_serving_authorities, the store refusal, and the verdict or plan fold over it -- with no host effect, which is the dissolution the exclusion row itself named. The two wet files, their wet-schedule rows, their exclusion rows and the reason/dissolution data only those rows used are deleted. Hermetic runs: fabric_capacity_standing_witness 17/17, spark_pair_serving_ apply_witness 5/5. Planting a resting-row fallback on the refused-store arm turns exactly the two new claims red. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
Author
|
Superseded by #12478 (landed first with the supplied off-fleet premise). A follow-up trims its live-read claims per operator direction: wet witnesses stay hermetic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the srv1-only floor failure:
local-repo wet lane: 2 refusal(s)onfabric_capacity_standing_wet_witnessandspark_pair_serving_apply_wet_witness.Cause. Both wet witnesses read the runner's own
hostnameand asserted the refusal that a host with no dashboard instance produces.dashboard_instance_for_hostdeclares instances for srv1, srv2 and macbook. The CI runners include srv1, so there the lookup resolved and the claims failed; on srv3/srv4 they passed. Over the last 60 witness runs, every srv1 floor that reached the wet step failed these two, and srv3/srv4 never did. The job cgroup showed no OOM and zero memory pressure, so this was not memory. The verdict depended on which runner picked up the job, not on the change.Change. Both claims now take the executor as a supplied value (
off-fleet.invalid: the RFC 2606.invalidTLD guarantees no declared instance answers for it), plus a supplied instant. They move into their existing hermetic sibling files. They still execute the real read route:current_pair_serving_authorities, the store refusal, and the verdict or plan fold over it. That route has no host effect, which is the dissolution the exclusion row itself named ("driven hermetically with a fixed executor … re-enrolls as an ordinary hermetic discovery row, drops off local_repo_wet_schedule, and this row deletes"). Deleted:_wet_witness_test.dagfiles;local_repo_wet_schedulerows;WitnessExclusionRows, and theexcl_local_repo_wet_executor_identity_{reason,dissolve}data only they used.What is no longer executed by any witness: the live entry's own
hostname/clock read (observe_executor_reach). That read is host state by nature, and it is the part that made the verdict host-dependent.Evidence (claim_batch
--hermetic, current main):fabric_capacity_standing_witness: 17/17 pass;spark_pair_serving_apply_witness: 5/5 pass.HostStoreRefusedarm ofcurrent_pair_serving_authoritiesturns exactly the two new claims red (16/17, 4/5, exit 1). Every other claim stays green.🤖 Generated with Claude Code