Repository navigation
test.claim witnesses: explicit imports for every bare provider (emit_subject_clean_frontier, deploy_access_privilege) - #12380
Merged
Merged
Conversation
…subject_clean_frontier, deploy_access_privilege) emit_subject_clean_frontier_witness had zero imports and resolved only through the bare channel's corpus census; deploy_access_privilege_witness had one import, so its bare channel was off and 16 names resolved by accident of closure (rostered debt). Both now import every declaration they use; the 16 roster rows retire ImportsFixed. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
Author
|
The reported failure, taken from the floor log (#12354's failing run 36265763185, head
I have not reproduced it end to end. No floor run of this head exists over a The upstream cause is not fixed here. Consumer selection treats a named-argument label — sent from keen-deer-265 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work item: zero-import test witness files fail when a changed-declaration consumer pull brings them into the floor plan.
Change
test.claim.emit_subject_clean_frontier_witnesshad zero imports, so it resolved only through the bare channel's whole-corpus census, and a corpus change elsewhere could break it. It now imports every declaration it uses (fromgunbc.emit_subject_clean_frontier,tools.emission_entry_instrument,std.*,extdeps.*).test.claim.deploy_access_privilege_witnessis not zero-import. It had one import, which turns its bare channel off, so 16 names resolved only by chance. On main it does not resolve on its own (effect-summary refusals naming the unimported callees). It now imports all 16, and their 16 rows inv2.workflow.floor_unimported_bare_provider_debt_rostermoveActiveDebt -> Retired { cause: ImportsFixed }.Evidence (and what is missing)
extdeps.languages.json.number. That is most likely the binary predating Int->Nat refinement PR1: subtraction leaves Nat, count/length return Nat, Bool as Int refused by the checker #12227's Nat typing; only the floor at head can settle it.Not fixed here: the other zero-import files
About 250
test.claimfiles have no import lines. By design (unimported_bare_providers: "a zero-import file is on the bare channel and owes nothing here") they are not debt under the rule, and fixing them is not mechanical: name-to-declarer inference picks up lambda and local noise (single-letter binders matched to unrelated test modules), and each file needs its own resolve to verify. List:for f in $(grep -rl '^module test\.claim' dag src/v2); do grep -q '^import ' $f || echo $f; done. I recommend a follow-up that decides structurally whether a zero-import file may stay on the census channel, rather than 250 hand edits.🤖 Generated with Claude Code