Repository navigation
Activation witness: forbid enable fused with --now, not the flag itself - #12347
Merged
Merged
Conversation
emitted_activation_is_never_the_fused_enable_now refused any --now in the apply text; #11204 added retirement inhibition (systemctl mask --now) to the runner family header, so the row was red on text carrying no activation. The prohibition is now the enable verb followed by --now. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the latent-red triage from #12339. This PR covers one root cause:
emitted_activation_is_never_the_fused_enable_now(test.claim.runner_service_activation_witness).Red on main f17c19a. Probed per conjunct:
'--now'(holds)--now(so the second conjunct fails)'--now'(holds)The bare
--nowis the runner-slot family header,gunbc.fleet_converge_planrunner_slot_apply_family_header: "retirement inhibition (systemctl mask --now)". That text first appeared in #11204 (1d5c804).Re-derivation (§6b, and §4d's over-prohibition arm). The row exists to stop activation from being the fused
systemctl enable --nowthat ignores readiness.mask --nowon an authorized surplus unit is a different verb, and there stopping the unit now is the point. So the fold is right and the claim prohibited more than its subject. The prohibition is now the enable verb followed by--now, in both renderings ('enable' '--now'andenable --now), built fromsystemctl_enable_verb. The positive pole asserts the same pattern does match the fused builder, so it is not a pattern that can never match.Evidence. Local
claim_batch, every function in the file on this head: all PASS exceptgrants_carry_one_enable_and_one_start_per_desired_slot, which is a different cause, fixed in #12343.🤖 Generated with Claude Code