Repository navigation
Privileged-population witness: count the microVM network readbacks that #11751 added - #12346
Merged
Merged
Conversation
…1751 added witness_population_tracks_the_slot_roster summed six terms of runner_host_privileged_operations; #11751 (99c2d33) appended microvm_network_granted_operations to every host, so the row was red by that list's length. The term is derived from the named list. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the latent-red triage from #12339. This PR covers one root cause:
witness_population_tracks_the_slot_roster(test.claim.executor_privileged_operation_witness).Red on main f17c19a. Measured with a local
gunbc runon srv3's population: the fold gives 140; the claim's six terms sum to 135 (64 teardown bound + 15×3 + 5 host-wide + 19 fabric + 2 allocation-store). It turned red with #11751 (99c2d33). That PR appendedgunbc.runner_microvm_network_convergemicrovm_network_granted_operations(5 readback ops) torunner_host_privileged_operationsfor every host.Re-derivation (§6b).
runner_host_privileged_operationsis the concatenation of seven named lists. The claim summed six of them, so the claim is the earliest unjustified link. The fold's addition is documented at its home: the job user gets the readbacks only, and the installs stay off the roster so it is never handed the stage-then-install pair. The fix adds the seventh term as that named list's length, not a literal, and asserts the term is nonempty, as the row already does for the host-wide list.One question for the fleet owner, not decided here. The readbacks are granted on every host, including srv3 and srv4, which run no microVM slot. They are reads, and the module's note justifies that. But a host-scoped roster would be the least-privilege form. That is a policy call, so I'm reporting it to the parent session rather than changing the fold.
Evidence. Local
claim_batch, every function in the file: 14/14 PASS on this head.🤖 Generated with Claude Code