Repository navigation
sccache witness: assert the elevated, quoted mv that #10568 renders - #12344
Merged
Merged
Conversation
srv4_sccache_prereq_pins_version_and_digest pinned the pre-#10568 hand-rendered `sudo mv ... /usr/local/bin/sccache` spelling. #10568 (84b6739) routed the step through sudo_elevate_argv with every word quoted, deliberately; the claim was the unjustified link. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the latent-red triage from #12339. This PR covers one root cause:
srv4_sccache_prereq_pins_version_and_digest(test.claim.runner_host_deploy_witness).Red on main f17c19a, and it turned red with #10568 (84b6739). That PR routed the sccache install's
mvandchmodthroughextdeps.sudo.elevationsudo_elevate_argvand single-quoted every word, on purpose: so that a missing NOPASSWD grant refuses instead of prompting. The claim's third pattern still read the old hand-rendered spelling,.../sccache' /usr/local/bin/sccache, with an unquoted destination.Re-derivation (§6b). The fold change was deliberate and correct, so the claim is the earliest unjustified link. What the row owes is two things:
sccache-v0.15.0-<arch>-unknown-linux-musl/sccacheThe new pattern
'mv' '/tmp/sccache-v0.15.0-aarch64-unknown-linux-musl/sccache' '/usr/local/bin/sccache'is spelled from that layout and the POSIX quoting rule. It was not copied from the rendered script.Evidence. Local
claim_batch, every function in the file: 10/10 PASS on this head. On main this row FAILs.🤖 Generated with Claude Code