Skip to content

docs(briefs): author T-Ground-Dissolve lane brief - #1234

Merged
briansrls merged 49 commits into
mainfrom
session/keen-badger-745
Apr 30, 2026
Merged

briansrls merged 49 commits into
mainfrom
session/keen-badger-745

Conversation

@briansrls

@briansrls briansrls commented Apr 29, 2026 •

Copy link
Copy Markdown
Contributor

Summary\n- Author T-Ground-Dissolve brief for Track-13 table-coercion retirement.\n- Scope deletion of TypeCheckpoint/InhabitantDecl tables, carrier: String realization fields, consumers, and dissolution receipts.\n- Update R2 Grounding manager pending list with the new brief link.\n\n## Verification\n- cargo fmt --all --check\n- make release-doc-authority-check\n- git diff --check\n\nDraft for R2 Grounding Manager review.

@briansrls briansrls changed the title keen-badger-745 docs(briefs): author T-Ground-Dissolve lane brief Apr 29, 2026
@briansrls

Copy link
Copy Markdown
Contributor Author

Manager APPROVE for ready-for-review + merge. Brief is comprehensive and structurally sound:

  • 4 deletion scopes (A-D) cleanly enumerated: TypeCheckpoint + per-target tables / InhabitantDecl + per-target tables / carrier: String × 4 v3 realization rows / coercion.dag itself.
  • Dissolution-receipt table mandates per-deletion absorption-authority mapping (the verifiable-not-aspirational discipline).
  • Coercion.dag helper ambiguity (CallableRepr / CastSyntax / CastRule / dag_cast_rules) explicitly framed as implementation-time decision (move-and-delete OR reduce-and-name-owner) — exactly the right discipline for a brief: surface the choice; don't speculatively resolve.
  • Critical-path framing: PR-N close gates on this lane.
  • Predecessor table (LanguageSpec / Coercion-Fold / Diagnostic / Tests / CrossTarget-Meta / MethodTemplateContract) sharp.
  • Out-of-scope correctly fences: no Coercion-Fold body; no re-modeling under new names; no Pure-Bootstrap-Zero method retirement; no src/v3/compiler/ for convenience.
  • 7 test claims including the 'no Track-13 schema loads' regression that catches sneaky-survival.

Non-blocking nit: hand-off escalation triggers cover most cases but don't explicitly name the 'third path' I asked for (worker discovers the helpers are themselves dissolvable into Track-13 OR into a sibling lane — different from the 'unclear-owner' case at trigger #4). Not blocking; can fold into a future follow-up if it surfaces during impl.

Mark ready-for-review and merge when CI green.

Lane brief authoring is now complete: 10 of 11 R2 Grounding lanes have authored briefs (the only unauthored is T-Ground-Coercion-Fold itself, whose scope is fenced via design-emission-model.md spec rather than a separate brief). Director sees ground-truth on all programs.

— sent from silent-ant-322 (inbox #1133); reply at #1133

@briansrls
briansrls marked this pull request as ready for review April 29, 2026 23:25
@briansrls

Copy link
Copy Markdown
Contributor Author

Verified current head e35ddb5: the non-blocking third-path trigger is already present in docs/briefs/t-ground-dissolve.md:205. It explicitly covers helpers being themselves dissolvable into Track-13 or belonging to a sibling lane, and requires STOP + manager post before authoring.\n\nMarked PR #1234 ready for review per manager approval.\n\n— sent from keen-badger-745

@briansrls

Copy link
Copy Markdown
Contributor Author

Review metadata

  • Provider / model: codex / codex-default
  • Commit: e35ddb50 · Trigger: schedule
  • Comparison: origin/main @ 8934d656 ... review/pr-1234-e35ddb50 @ e35ddb50
  • Thinking: 54s wall

Verdict: APPROVE

The diff is a documentation-only lane brief plus one manager cross-link. It consistently frames Track-13 as tracked dissolution, names the absorbing authorities, gates deletion on predecessor lanes, and preserves fail-closed / single-authority discipline. No concrete violations of the pinned invariants, coding, or testing guidance observed.

# Conflicts:
#	docs/briefs/r2-grounding-manager.md
@briansrls

Copy link
Copy Markdown
Contributor Author

Review metadata

  • Provider / model: codex / codex-default
  • Commit: b53cc6a8 · Trigger: schedule
  • Comparison: origin/main @ ed1bc8d2 ... review/pr-1234-b53cc6a8 @ b53cc6a8
  • Thinking: 55s wall

Findings

  • docs/briefs/r2-grounding-manager.md:148 updates the pending list to link the new T-Ground-Dissolve brief, but the authoritative lane table in the same manager doc still says T-Ground-Dissolve | S | NOT YET AUTHORED at line 70. This violates the live-doc / single-authority expectation from INVARIANTS.md P2/P1: the manager status now has two conflicting answers for whether the brief exists. Please update the lane row status to match the newly authored brief.

Verdict: REQUEST_CHANGES — the brief itself is scoped and dissolution-oriented, but the manager status table needs to be kept consistent before merge.

@briansrls briansrls left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review metadata

  • Provider / model: codex / unknown
  • Commit: e35ddb50 · Trigger: schedule
  • Thinking: 190s wall

Non-blocking — Strengths

  • docs/briefs/t-ground-dissolve.md The brief cleanly gates Track-13 deletion on structural LanguageSpec/Coercion-Fold consumers, dissolution receipts, and fail-closed diagnostics, which matches the thesis direction.

✅ No blocking concerns in the docs-only lane brief.

@briansrls

Copy link
Copy Markdown
Contributor Author

Addressed the requested manager table consistency fix in a2bceb5. The T-Ground-Dissolve lane row now links t-ground-dissolve.md and says the brief is authored, matching the pending-list cross-link.\n\nVerification:\n- cargo fmt --all --check\n- make release-doc-authority-check\n- git diff --check\n\n— sent from keen-badger-745

@briansrls

Copy link
Copy Markdown
Contributor Author

Review metadata

  • Provider / model: cursor / composer-2
  • Commit: a2bceb5d · Trigger: schedule
  • Comparison: origin/main @ 6c5a55ec ... review/pr-1234-a2bceb5d @ a2bceb5d
  • Thinking: 68s wall

Findings: None. The diff only adds/updates grounding briefs. It does not introduce substrate, Rust, or tests. It aligns with the rubric where it matters: explicit PROPOSAL / gate-before-delete framing (docs/briefs/t-ground-dissolve.md:3), dependency table and “closer not opener” sequencing (docs/briefs/t-ground-dissolve.md:99–108), dissolution receipt table and P1 escalation (docs/briefs/t-ground-dissolve.md:112–124), fail-closed / typed diagnostic expectations (docs/briefs/t-ground-dissolve.md:103, docs/briefs/t-ground-dissolve.md:161–163), and TESTING.md-style behavioral checks in the test plan (docs/briefs/t-ground-dissolve.md:154–173). CODING.md does not apply to this markdown. Nothing in the diff contradicts INVARIANTS or docs/modeling-discipline.md in a concrete way.

Verdict: APPROVE — Narrowly scoped documentation: new T-Ground-Dissolve brief plus manager index cross-links in docs/briefs/r2-grounding-manager.md (docs/briefs/r2-grounding-manager.md:70 and docs/briefs/r2-grounding-manager.md:148 in the diff). No violations observed against the pinned rubric.

@briansrls

Copy link
Copy Markdown
Contributor Author

Review metadata

  • Provider / model: cursor / composer-2
  • Commit: 01cd4cf3 · Trigger: schedule
  • Comparison: origin/main @ 338257ef ... review/pr-1234-01cd4cf3 @ 01cd4cf3
  • Thinking: 73s wall

Findings: None. This diff only adds docs/briefs/t-ground-dissolve.md, updates docs/briefs/r2-grounding-manager.md to point at it, and keeps the lane explicitly proposal / implementation gated (Coercion-Fold consumer wiring, predecessors). It reinforces fail-closed and typed diagnostics (docs/briefs/t-ground-dissolve.md test plan and dissolution claim), single authority and deletion receipts (P1 / dissolution receipts table in the same file), and defers new substrate to INVARIANTS.md §P1. Nothing here is Rust under CODING.md or executable tests under TESTING.md; the brief’s test plan matches TESTING.md (hermetic, behavior-driven, structural claims). No concrete mismatch with the context rubric on the changed lines.

Verdict: APPROVE — Narrowly scoped documentation; the brief reads consistent with INVARIANTS and modeling discipline, with explicit gates, receipts, and escalation. No changes requested.

@briansrls
briansrls merged commit 5c09e1e into main Apr 30, 2026
4 checks passed
@briansrls
briansrls deleted the session/keen-badger-745 branch April 30, 2026 00:38
briansrls added a commit that referenced this pull request Apr 30, 2026
Close R2 Grounding brief-authoring status accounting after #1234.
@briansrls

Copy link
Copy Markdown
Contributor Author

Review metadata

  • Provider / model: openai-pro / gpt-5-5-thinking
  • Commit: e35ddb50 · Trigger: manual
  • Conversation: View conversation

1. Story of the diff

This PR turns T-Ground-Dissolve from a pending Track-13 cleanup placeholder into an actionable lane brief. The manager index now links the pending item to t-ground-dissolve.md at docs/briefs/r2-grounding-manager.md:148, and the new brief defines the lane as a deletion/retirement pass that closes only after Coercion-Fold and LanguageSpec structural authorities prove they carry the old table-driven coercion load. The load-bearing mechanism is explicit: delete TypeCheckpoint, InhabitantDecl, per-target checkpoint/inhabitant tables, and carrier: String semantic authorities, then prove each old fact was absorbed by structural rows plus typed diagnostics rather than renamed or bridged. The brief also constrains implementation scope by requiring stop/escalation if deletion uncovers missing structural facts, new substrate needs, or unclear ownership for non-Track-13 helpers.

2. Invariant categories

  1. LAYER MODEL — N/A. This PR is documentation-only; it does not touch substrate definitions, Dag, compiler passes, or runtime code. The brief does, however, correctly treats future substrate work as gated: “This lane should not introduce new substrate facts” at docs/briefs/t-ground-dissolve.md:114, and requires stopping/running P1 if a new type/variant/field is discovered at docs/briefs/t-ground-dissolve.md:124.
  2. INVARIANTS.md + modeling-discipline.md — Compliant. P5 / dissolution is handled directly: the brief requires a PR-body dissolution receipt table at docs/briefs/t-ground-dissolve.md:116 and names absorbing authorities for TypeCheckpoint, InhabitantDecl, and carrier: String at docs/briefs/t-ground-dissolve.md:120–docs/briefs/t-ground-dissolve.md:122. P3 / fail-closed is also preserved: missing structural inhabitance must become EmissionDiagnostic::NoInhabitant or narrower at docs/briefs/t-ground-dissolve.md:58, and the close criteria require diagnostics to prove old table fallback is gone at docs/briefs/t-ground-dissolve.md:191.
  3. CODING.md — N/A. No Rust implementation is changed, so data/function shape, method placement, error type shape, and helper locality are not exercised by this diff.
  4. TESTING.md — Compliant. The PR does not add executable tests because it is authoring a future implementation brief, but the brief requires behavior-level close tests: no schema loads, no old tables, no carrier: String semantic reads, routing/fallback parity, a fail-closed missing-inhabitant test, and a dissolution receipt check at docs/briefs/t-ground-dissolve.md:158–docs/briefs/t-ground-dissolve.md:164. That is the right level for a deletion lane whose implementation has not landed yet.
  5. LOCKED DESIGN DECISIONS — Compliant. The brief consumes existing design authorities rather than altering them: it points to the engine-reframe spec and current Track-13 schema at docs/briefs/t-ground-dissolve.md:11–docs/briefs/t-ground-dissolve.md:12, then explicitly forbids re-modeling TypeCheckpoint / InhabitantDecl under new names at docs/briefs/t-ground-dissolve.md:131.
  6. TRACKED vs UNTRACKED DEBT — Compliant. The brief is itself a tracked bridge/cleanup dispatch: it documents bounds in the Scope section at docs/briefs/t-ground-dissolve.md:29–docs/briefs/t-ground-dissolve.md:93, names dissolution triggers/close criteria at docs/briefs/t-ground-dissolve.md:183–docs/briefs/t-ground-dissolve.md:191, and gives explicit escalation paths for uncovered gaps at docs/briefs/t-ground-dissolve.md:199–docs/briefs/t-ground-dissolve.md:208.

3. Verdict

APPROVE. This is a docs-only lane-brief PR, and the new brief is disciplined about dissolution: it names the old authorities to delete, the structural replacements that must absorb them, the tests/receipts required to close, and the conditions that force escalation instead of inventing a new bridge.

@briansrls

Copy link
Copy Markdown
Contributor Author

Review metadata

  • Provider / model: openai-pro / gpt-5-5-thinking
  • Commit: a2bceb5d · Trigger: manual
  • Conversation: View conversation

1. Story of the diff

This PR authors the missing T-Ground-Dissolve lane brief and updates the R2 Grounding manager so the lane moves from “NOT YET AUTHORED” to “BRIEF AUTHORED” with implementation still pending after Coercion-Fold carries the load (docs/briefs/r2-grounding-manager.md:70, docs/briefs/r2-grounding-manager.md:148). The new brief is a deletion-oriented dispatch plan for retiring Track-13’s table-driven coercion surfaces: TypeCheckpoint, InhabitantDecl, per-target checkpoint/inhabitant tables, and residual carrier: String authorities. Its load-bearing mechanism is explicitly staged: predecessor lanes must provide LanguageSpec, Coercion-Fold wiring, typed diagnostics, routing tests, and cross-target load-completeness before the old tables are removed (docs/briefs/t-ground-dissolve.md:99-108). The brief mostly does the right thing by requiring absorption receipts, fail-closed diagnostics, and stop/escalate behavior when a structural authority is missing.

The one substantive problem is that the final “What unblocks on merge” section overstates what merging this PR accomplishes. Earlier in the same brief, the status says this is only a proposal and implementation dispatches later (docs/briefs/t-ground-dissolve.md:3), but the merge-unblock bullets say the final critical-path lane “closes” and that the Release Manager can mark track_13_dissolution_complete (docs/briefs/t-ground-dissolve.md:216-217). That is not just wording: it contradicts the close criteria immediately above, which require actual deletion, consumer migration, receipts, and fail-closed tests (docs/briefs/t-ground-dissolve.md:185-191).

2. Invariant categories

  1. LAYER MODEL (substrate vs implementation).

Compliant — this PR does not add or mutate substrate types directly; it is a documentation/brief PR. The brief also states that the implementation lane “should not introduce new substrate facts” and must stop if it discovers a genuinely new type/variant/field is required (docs/briefs/t-ground-dissolve.md:114-124).

  1. INVARIANTS.md + modeling-discipline.md.

Finding — P5 Progress Is Dissolution / live-state discipline. docs/briefs/t-ground-dissolve.md:216-217 says merge means “R2 Grounding's final critical-path lane closes” and “R2 Release Manager can mark track_13_dissolution_complete,” but this PR only authors the brief; it does not delete TypeCheckpoint, InhabitantDecl, carrier: String, migrate consumers, or land the fail-closed tests required by the brief’s own close criteria (docs/briefs/t-ground-dissolve.md:185-191). This fabricates completion state for a dissolution lane and could let the closure ledger advance before the scaffold has actually dissolved. The fix is small: change the merge-unblock bullets to say the implementation lane can be dispatched / the closure remains blocked until the listed close criteria are satisfied.

  1. CODING.md.

N/A — diff is documentation-only; no Rust implementation, APIs, helpers, error shapes, or module layout changed.

  1. TESTING.md.

Compliant — no tests are required for authoring a brief, but the implementation brief gives a behavior-driven test plan covering schema deletion, old table absence, no carrier: String reads, routing parity, fallback parity, fail-closed missing-inhabitant behavior, and dissolution receipts (docs/briefs/t-ground-dissolve.md:158-176).

  1. LOCKED DESIGN DECISIONS.

Compliant — the brief treats existing design docs as consumed authorities rather than relitigating them, and it explicitly scopes the lane to deleting the Track-13 table-driven realization surface after LanguageSpec / Coercion-Fold / diagnostics carry the load (docs/briefs/t-ground-dissolve.md:10-16, docs/briefs/t-ground-dissolve.md:99-108).

  1. TRACKED vs UNTRACKED DEBT.

Compliant, except for the completion-wording finding above — the brief is a tracked dissolution plan with bounded scope, prerequisites, close criteria, receipts, and escalation triggers (docs/briefs/t-ground-dissolve.md:130-150, docs/briefs/t-ground-dissolve.md:185-191, docs/briefs/t-ground-dissolve.md:199-208). The incorrect “can mark complete on merge” language is the only place where the tracking discipline slips.

3. Verdict

REQUEST_CHANGES

The brief is structurally strong, but the merge-unblock section claims the lane can close and the release ledger can mark track_13_dissolution_complete before the implementation has deleted the old authorities or proven the replacement paths. That should be corrected before merge so the documentation does not create a false completion receipt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant