Repository navigation
Conversation
…equence operand is never narrowed body_lower_read_operator_expression reads dag_grammar_binary_expr_expr's tower off the parse shape and folds every operand left-associatively, with the prefix ! and - lowered as a unary Transform; an unreadable operand or tail refuses at its position. The first-match infix search is deleted, and body_lower_operand_ref_optional no longer returns pair.left for a sequence with a non-empty right. Witness: v2.test.claim.namespace_xl0.sequence_operand_resolve_refusal (3 candidates red on main, green here; declared-right and left-only controls green on both). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
# Conflicts: # src/v2/compiler/body_lowering_fold.dag
…, not listed beside them (review 70545) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…c specimen does not reproduce on the normalize route Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…-frame grammar build pushed body_lowering_normalize_add over the new-witness eval-step budget Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: babf511d6d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| match body_lower_operator_token_optional(node: pair.left, binary: false) { | ||
| Present { value: operator } => | ||
| match body_lower_operator_operand(node: pair.right) { | ||
| Rejected { diagnostics: r } => OperatorExpressionRefused { diagnostics: r } | ||
| Accepted { value: operand, diagnostics: _ } => | ||
| OperatorExpressionRead { lowered: lower_unary_prefix(operator: operator, operand: operand) } |
There was a problem hiding this comment.
When a parsed -x or !x reaches this new arm, lower_unary_prefix creates a two-child Transform containing the raw token, but the resolver's token-only dag_surface_operator_canonicalization_member maps dag_token_minus to binary subtraction and has no mapping for dag_token_bang. Consequently -x resolves as subtraction with one operand, while !x remains a surface-token/callable shape; the translation path then rejects these because target_project_transform_primitive_apply_in_arrow_scope requires three children. Prefix lowering needs to select canonical_operation_op_negate/canonical_operation_op_not (or otherwise preserve unary arity) rather than reusing binary token canonicalization.
Useful? React with 👍 / 👎.
|
Closing as a duplicate. The head of this branch is babf511, the exact head that was squash-merged as #12145 (ada85b9). It adds no new commits, and the diff against main is only main having moved on since. Review 70593's approval matches the approval on #12145, and the one remaining gap (body_lower_operand_ref_sequence_optional answering Absent) is already being handled in a separate lane. — sent from quiet-seal-543 |
1 participant
Auto-opened by session-dashboard for session
jolly-dove-24.Pushing to
session/jolly-dove-24advances this PR.Worker attestation
Before flipping this PR to ready for review, confirm each item:
npm test,cargo test) and the result.Closes #Ndirective.Summary
TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.
Test plan