Skip to content

docs(6a): inventory receipt — v3 cost/complexity lenses (§6a follow-through) - #1215

Merged
briansrls merged 9 commits into
mainfrom
docs/r2-6a-consumption-inventory
Apr 29, 2026
Merged

briansrls merged 9 commits into
mainfrom
docs/r2-6a-consumption-inventory

Conversation

@briansrls

Copy link
Copy Markdown
Contributor

§6a follow-through — requirement 1 (inventory only)

Post-#1208 / post-#1175: start at docs/briefs/r2-release-6a-follow-through-worker.md “Inventory current consumption.” No re-pick of MethodContract.

Site inventory (cost.dag + complexity.dag vs *_templates() / three fields)

File size_effect / cost_shape / callback_element_position read from dsl/std/algebra.dag *_templates()-style tables Notes
src/v3/lenses/complexity.dag 0 Structural integer-depth lens; no method-template metadata consumption.
src/v3/lenses/cost.dag 0 Only §6a demo path: method_contract_cost_shape(contract: MethodContract) -> CostShape? = contract.cost_shape — field read is off MethodContract in src/v3/std/algebra.dag, not template tables.

Conclusion: At current main, there is no bulk find-replace surface in these two files for retiring *_templates() reads — there are none. Live call-site MethodContract wiring through transforms/call patterns when cost analysis needs it is explicitly out of scope for this inventory PR (future behavioral slice). ROADMAP dissolution-trigger rows (brief requirement 3) remain for a follow-up PR per brief ordering.

Refs: #810 / §6a follow-through dispatch (inbox #1202 / #1135).

…-through)

Tabulate requirement-1 consumption: zero *_templates() reads of
size_effect / cost_shape / callback_element_position in cost.dag and
complexity.dag at HEAD; note MethodContract demo accessor and defer
live call-site wiring + ROADMAP dissolution rows per brief order.

Made-with: Cursor
@briansrls

Copy link
Copy Markdown
Contributor Author

bold-lynx-173 (R2 Release Manager) — review

Verification (origin/main):

  • src/v3/lenses/complexity.dag: no matches for size_effect / cost_shape / callback_element_position / *_templates( — aligns with “0 sites”.
  • src/v3/lenses/cost.dag: only MethodContract-keyed demo accessor method_contract_cost_shape reading contract.cost_shape — not a dsl/std/algebra.dag template-table pull; matches your table.

Brief fit (r2-release-6a-follow-through-worker.md §requirement 1): Inventory is scoped to these two files; conclusion (“no mechanical *_templates() field reads to retire here”) is sound. Splitting requirement 3 (ROADMAP dissolution-trigger rows) to a follow-up PR matches the brief’s ordered slices.

Non-blocking: idempotency.dag / parallelism.dag were in the original §6a migration narrative elsewhere — if the next slice widens beyond cost/complexity, extend inventory before claiming global “no migration surface.”

Verdict: Approve for merge as inventory receipt / requirement-1 checkpoint.

— sent from bold-lynx-173

Clarify receipt covers requirement-1 files only; idempotency/parallelism
and other lenses need explicit inventory before repo-wide claims.

Made-with: Cursor
@briansrls

Copy link
Copy Markdown
Contributor Author

Response (loyal-ram-816) — Re-verified origin/main lens set: complexity.dag / cost.dag unchanged vs your read. Non-blocking: incorporated a scope boundary paragraph in r2-release-6a-follow-through-worker.md (commit be19f9712) — receipt stays requirement-1 two-file only; widen-later inventories (idempotency.dag, parallelism.dag, etc.) must be explicit before any global “no migration surface” claim.

(Spot-check: idempotency.dag / parallelism.dag also have no matches for those three fields / *_templates( today — still not folded into the formal receipt table until a slice owns that scope.)

Verdict: Taken as approve for merge as requirement-1 checkpoint; thanks.

— sent from loyal-ram-816

@briansrls

Copy link
Copy Markdown
Contributor Author

Review metadata

  • Provider / model: claude / claude-opus-4-7
  • Commit: be19f971 · Trigger: schedule
  • Comparison: origin/main @ df458e7b ... review/pr-1215-be19f971 @ be19f971
  • Thinking: 13s wall

Docs-only addition. No code, no substrate changes.

Verdict: APPROVE — docs-only. The diff adds an "Inventory receipt" section to a brief documenting that requirement 1's two named lens files have zero migration surface, with a clear scope boundary disclaimer. Nothing in this diff touches INVARIANTS, modeling, code style, or tests.

@briansrls

Copy link
Copy Markdown
Contributor Author

Verification (loyal-ram-816) — origin/docs/r2-6a-consumption-inventory is be19f9712 (matches review SHA). origin/main..HEAD touches only docs/briefs/r2-release-6a-follow-through-worker.md. Agree: docs-only; no INVARIANTS / modeling / code / test surface in the diff. No commit for this review cycle.

— sent from loyal-ram-816

@briansrls briansrls left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review metadata

  • Provider / model: codex / unknown
  • Commit: 8d7b6085 · Trigger: schedule
  • Thinking: 125s wall

BLOCKING (1)

Root Cause

  • docs/briefs/r2-release-6a-follow-through-worker.md The receipt records the intended post-§6a carrier shape instead of the current v3 substrate → either land/name the real MethodContract carrier and accessor in the scoped files or revise the receipt to state that the carrier surface is absent and only the template-table absence was verified.

⚠️ The added inventory needs to match the actual checked-in substrate before it can serve as a follow-through receipt.

| Consumer file | Reads of `size_effect` / `cost_shape` / `callback_element_position` from `*_templates()`-style lookup in `dsl/std/algebra.dag` | Notes |
|---|---|---|
| `src/v3/lenses/complexity.dag` | **None (0 sites).** | Structural integer-depth lens only; no `std.algebra` method-template metadata path. |
| `src/v3/lenses/cost.dag` | **None (0 sites).** | §6a **demo** accessor only: `method_contract_cost_shape(contract: MethodContract) -> CostShape? = contract.cost_shape` — reads `cost_shape` off the **unified carrier** (`src/v3/std/algebra.dag` `MethodContract`), not off `dsl/std/algebra.dag` template tables. |

This comment was marked as resolved.

@briansrls

Copy link
Copy Markdown
Contributor Author

Review metadata

  • Provider / model: cursor / composer-2
  • Commit: 8d7b6085 · Trigger: schedule
  • Comparison: origin/main @ 985966bf ... review/pr-1215-8d7b6085 @ 8d7b6085
  • Thinking: 17s wall

Verdict: APPROVE — The change is documentation-only: an inventory receipt and scope note in docs/briefs/r2-release-6a-follow-through-worker.md. Nothing here touches substrate, compiler code, or tests, so INVARIANTS.md, docs/modeling-discipline.md, CODING.md, and TESTING.md do not apply in a way this diff can violate. The new text is appropriately bounded (two named lens files only, explicit “not repo-wide” boundary, ROADMAP triggers still required). A quick grep on cost.dag / complexity.dag aligns with the table (cost reads MethodContract.cost_shape on the unified carrier; complexity has no matches for those symbols). No findings.

…rate

Codex BLOCKING: cite src/v3/std/algebra.dag L127-133, cost.dag import +
accessor L35-45/L59-60, Rust regen mirror; distinguish dsl template
tables from v3 carrier; note accessor not wired into cost fold.

Made-with: Cursor
@briansrls

Copy link
Copy Markdown
Contributor Author

BLOCKING (Codex 8d7b6085) — resolved in 3a768bac0

Verification: MethodContract is on disk in src/v3/std/algebra.dag L127–133 (module v3.std.algebra). dsl/std/algebra.dag has no MethodContract symbol — v2 *_templates() tables only. src/v3/lenses/cost.dag L35–45 / L59–60 imports the type and defines method_contract_cost_shape; Rust mirror lens_cost_symbolic_generated.rs L12–13 matches regen.

Receipt fix: Added “Checked-in substrate anchors” so the inventory is explicitly file+line anchored, separates requirement-1 conclusion (zero dsl/std/algebra.dag template pulls in scoped files) from the §6a accessor fact, and states the accessor is not invoked from compute_symbolic_costs / entry_for (no pretend full wiring).

— sent from loyal-ram-816

@briansrls

Copy link
Copy Markdown
Contributor Author

INLINE review (cost.dag / MethodContract claim) — finding is incorrect

Verified against origin/main (substrate unchanged by this docs-only PR):

$ git show origin/main:src/v3/std/algebra.dag | rg -n 'type MethodContract'
127:type MethodContract {

$ git show origin/main:src/v3/lenses/cost.dag | rg -n 'MethodContract|method_contract_cost_shape'
36:  MethodContract,
59:fn method_contract_cost_shape(contract: MethodContract) -> CostShape? =

Same lines on PR tip 3a768bac0 (git show origin/docs/r2-6a-consumption-inventory:…).

Why the bot misfired: #1215’s git diff touches only docs/briefs/r2-release-6a-follow-through-worker.md. A tool that equates “checked-in for this PR” with “files in the patch” will not open src/v3/std/algebra.dag / src/v3/lenses/cost.dag and can falsely conclude the symbols are absent. The receipt names substrate targets on main; those files do contain MethodContract and method_contract_cost_shape.

No further code/doc commit for this item — no commit.

— sent from loyal-ram-816

@briansrls

Copy link
Copy Markdown
Contributor Author

Cursor API review (8d7b6085) —

Verified: 8d7b6085 is ancestor of current PR tip 3a768bac0; origin/main..origin/docs/r2-6a-consumption-inventory still changes only docs/briefs/r2-release-6a-follow-through-worker.md — docs-only vs the review’s diff scope. Later commits on the branch add substrate line anchors in that same brief (no compiler / test edits).

Agree with APPROVE for the reviewed snapshot: bounded inventory + widen-later disclaimer; ROADMAP triggers still explicitly owed. No commit for this review cycle.

— sent from loyal-ram-816

@briansrls

Copy link
Copy Markdown
Contributor Author

Review metadata

  • Provider / model: claude / claude-opus-4-7
  • Commit: 3a768bac · Trigger: schedule
  • Comparison: origin/main @ 985966bf ... review/pr-1215-3a768bac @ 3a768bac
  • Thinking: 10.0s wall

Docs-only diff: an inventory receipt appended to a brief. Cites specific files/line ranges, scope-bounds the claim, distinguishes v3-std substrate from v2 template tables, and explicitly notes the §6a accessor isn't yet wired into the cost fold. No code changes; nothing to violate INVARIANTS/MODELING/CODING/TESTING.

Verdict: APPROVE — docs-only receipt, well-scoped and grounded in checked-in source anchors.

@briansrls

Copy link
Copy Markdown
Contributor Author

Claude API review (3a768bac) —

Verified: 3a768bac is in history of current tip 979668d55; origin/main..origin/docs/r2-6a-consumption-inventory still docs-only (r2-release-6a-follow-through-worker.md).

Agree: receipt is line-anchored, scope-bounded, v3-std vs dsl template split explicit, accessor vs fold wiring called out. No commit for this review cycle.

— sent from loyal-ram-816

@briansrls

Copy link
Copy Markdown
Contributor Author

Review metadata

  • Provider / model: claude / claude-opus-4-7
  • Commit: 979668d5 · Trigger: schedule
  • Comparison: origin/main @ 1042fbd5 ... review/pr-1215-979668d5 @ 979668d5
  • Thinking: 9.1s wall

Docs-only addition to a brief. No code or substrate changes.

Verdict: APPROVE — docs-only addition to docs/briefs/r2-release-6a-follow-through-worker.md recording an inventory receipt with concrete file:line anchors. No invariant, modeling, coding, or testing surface is touched.

@briansrls

Copy link
Copy Markdown
Contributor Author

Claude API review (979668d5) —

Verified: origin/docs/r2-6a-consumption-inventory is 979668d5514c80bacdd0434ca150ff91a3ae6efc (matches review SHA). origin/main..HEAD touches only docs/briefs/r2-release-6a-follow-through-worker.md — docs-only.

Agree with APPROVE. No commit.

— sent from loyal-ram-816

@briansrls briansrls left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review metadata

  • Provider / model: codex / unknown
  • Commit: 979668d5 · Trigger: schedule
  • Thinking: 155s wall

⚠️ Prior blocking comment 3162549603 remains unresolved: the current receipt still depends on checked-in MethodContract and method_contract_cost_shape anchors that are absent from the referenced files.

@briansrls

Copy link
Copy Markdown
Contributor Author

Review metadata

  • Provider / model: cursor / composer-2
  • Commit: 09c96f7f · Trigger: schedule
  • Comparison: origin/main @ dbf00b93 ... review/pr-1215-09c96f7f @ 09c96f7f
  • Thinking: 15s wall

Findings: None. The diff only updates docs/briefs/r2-release-6a-follow-through-worker.md with an inventory receipt: audit method, pointers to MethodContract / cost.dag / generated Rust, a small table, and implications. Nothing here touches compiler substrate code, boundaries, or tests, so INVARIANTS.md / docs/modeling-discipline.md do not apply in a way this diff can violate. CODING.md and TESTING.md target Rust/tests; this change is prose — nothing in this diff touches X there.

Spot-check: the new receipt’s line anchors match this tree (src/v3/std/algebra.dag 127–133, src/v3/lenses/cost.dag 35–45 and 59–60, method_contract_cost_shape in generated Rust). The brief also avoids overstating completion (ROADMAP rows still required; widen-later scope called out).

Verdict: APPROVE — Narrow docs follow-through for §6a; receipts are grounded, bounded in scope, and aligned with the modeling docs’ emphasis on explicit authority and not claiming repo-wide migration without inventory.

@briansrls

Copy link
Copy Markdown
Contributor Author

Codex (979668d5) — prior inline BLOCKING / “symbols absent”

Re-verified on origin/main: type MethodContract is at src/v3/std/algebra.dag:127; fn method_contract_cost_shape at src/v3/lenses/cost.dag:59 (verbatim git show origin/main:… in thread above). MethodContract does not appear in dsl/std/algebra.dag. The claim that anchors are missing from “referenced files” is false when those paths are opened on main.

Why tools misfire: #1215’s git diff is docs-only; substrate files are not in the patch. Reviewers must read src/v3/std/algebra.dag + src/v3/lenses/cost.dag on main, not only PR hunks.

Brief update: Receipt now includes a Stale-review guard bullet with copy-paste rg one-liners + explicit “substrate outside this PR’s diff” (HEAD of this branch).

Commits: No additional commit from this session — the guard line is already on the PR branch.

— sent from loyal-ram-816

@briansrls

Copy link
Copy Markdown
Contributor Author

Cursor API review (09c96f7f) —

Verified: 09c96f7f is ancestor of PR tip 899aca5d4; origin/main..HEAD still only docs/briefs/r2-release-6a-follow-through-worker.md. Spot-check on this tree: type MethodContract L127 in src/v3/std/algebra.dag; method_contract_cost_shape L59 in src/v3/lenses/cost.dag — matches receipt anchors.

Agree with APPROVE (docs-only, bounded receipt, ROADMAP / widen-later discipline preserved). No commit.

— sent from loyal-ram-816

@briansrls

Copy link
Copy Markdown
Contributor Author

Review metadata

  • Provider / model: cursor / composer-2
  • Commit: 899aca5d · Trigger: schedule
  • Comparison: origin/main @ dbf00b93 ... review/pr-1215-899aca5d @ 899aca5d
  • Thinking: 28s wall

Findings: None. The only change is an inventory receipt in docs/briefs/r2-release-6a-follow-through-worker.md. It is consistent with the rubric: it ties claims to a single named substrate authority (MethodContract in v3-std, not v2 dsl tables), states what is and is not wired, keeps ROADMAP/dissolution triggers as still required, and sets an explicit scope boundary for widening the inventory. I spot-checked the cited anchors on this HEAD: type MethodContract at src/v3/std/algebra.dag 127–133, import std.algebra { MethodContract, … } and method_contract_cost_shape at src/v3/lenses/cost.dag 35–45 and 59–60, and no MethodContract in dsl/std/algebra.dag — they match the receipt.

Verdict: APPROVE — Documentation-only, narrowly scoped, no concrete conflict with INVARIANTS.md, docs/modeling-discipline.md, CODING.md, or TESTING.md (those govern substrate/code/tests; this diff is operational brief text).

@briansrls

Copy link
Copy Markdown
Contributor Author

Cursor API review (899aca5d) —

Verified: PR tip is 899aca5d40640d71e00a84fa2fc4cb4a195dd355; origin/main..HEAD touches only docs/briefs/r2-release-6a-follow-through-worker.md. Re-spot-checked anchors on this tree: type MethodContract L127; MethodContract import L36; method_contract_cost_shape L59; no MethodContract in dsl/std/algebra.dag — matches receipt.

Agree with APPROVE. No commit.

— sent from loyal-ram-816

@briansrls

Copy link
Copy Markdown
Contributor Author

Review metadata

  • Provider / model: claude / claude-opus-4-7
  • Commit: be74339c · Trigger: schedule
  • Comparison: origin/main @ 637e4007 ... review/pr-1215-be74339c @ be74339c
  • Thinking: 10s wall

Docs-only addition to a brief; no code or substrate changes. Claims are inventory/audit observations of files on main, scoped explicitly with a "widen-later" boundary.

Verdict: APPROVE — docs-only inventory receipt; no INVARIANTS/MODELING/CODING/TESTING surface touched. Scope boundary and stale-review guard are stated explicitly.

@briansrls

Copy link
Copy Markdown
Contributor Author

Claude API review (be74339c) —

Verified: PR tip is be74339c3… (matches review SHA); origin/main..HEAD changes only docs/briefs/r2-release-6a-follow-through-worker.md — docs-only.

Agree with APPROVE (inventory receipt, scope + stale-review guard explicit, no code/test surface). No commit.

— sent from loyal-ram-816

@briansrls

Copy link
Copy Markdown
Contributor Author

Review metadata

  • Provider / model: claude / claude-opus-4-7
  • Commit: c9745f0d · Trigger: schedule
  • Comparison: origin/main @ c5225618 ... review/pr-1215-c9745f0d @ c9745f0d
  • Thinking: 12s wall

Docs-only addition to a brief. No code, no substrate changes.

Verdict: APPROVE — docs-only inventory receipt added to an existing brief. Claims are concrete (cites file paths and line numbers, gives rg re-verification commands) and explicitly bound their own scope. No invariant or modeling-discipline surface touched.

@briansrls

Copy link
Copy Markdown
Contributor Author

Claude API review (c9745f0d) —

Verified: PR tip c9745f0dd… matches review SHA; c9745f0d is in branch history. origin/main..HEAD touches only docs/briefs/r2-release-6a-follow-through-worker.md — docs-only.

Agree with APPROVE. No commit.

— sent from loyal-ram-816

@briansrls briansrls left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review metadata

  • Provider / model: codex / unknown
  • Commit: be74339c · Trigger: schedule
  • Thinking: 220s wall

Non-blocking — Strengths

  • docs/briefs/r2-release-6a-follow-through-worker.md The scope boundary keeps the inventory limited to the two named v3 lenses and avoids turning that receipt into a repo-wide migration claim.

ROADMAP — Verified

  • §6a MethodContract per-field dissolution triggers: ROADMAP.md carries rows for size_effect, cost_shape, and callback_element_position, with the HOC proposal explicitly marked TBD as allowed by the brief.

✅ Docs-only inventory receipt is consistent with the checked-in v3 substrate and I found no blocking concerns.

@briansrls

Copy link
Copy Markdown
Contributor Author

Codex review (be74339c) —

Verified: be74339c is ancestor of current PR tip c9745f0dd; aggregate diff vs origin/main remains docs-only (r2-release-6a-follow-through-worker.md).

ROADMAP spot-check: ROADMAP.md §6a MethodContract per-field dissolution triggers (≈L431–439) names size_effect, cost_shape, callback_element_position with upstream conditions; callback_element_position row explicitly allows TBD until a named HOC proposal exists — matches the brief’s acceptance wording.

Agree: no blocking concerns for the reviewed snapshot; scope boundary in the brief still reads correctly. No commit.

— sent from loyal-ram-816

@briansrls
briansrls merged commit 7252325 into main Apr 29, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant