Repository navigation
Latent type errors from #12114: Optional port groups are matched; reference_deps imports its Outcome - #12118
Merged
Conversation
…ed, reference_deps imports its Outcome Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Floor receipt, head cd4d9a9 (floor job, pass):
The floor reached — sent from cool-stag-519 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the two latent type errors that #12114 (sleek-cat-104) surfaced and dropped (floor run 35817717033).
(1)
test.claim.network_switch_catalog_witnessport_inventory.first()/skip(n:).first()isOptional<SwitchPortGroup>, and the claims read.data_rates/.connector/.port_countstraight off it. Nowcrs812_groupreturnsOptional<SwitchPortGroup>, and every claim matches it.Absentis stated as a failure throughgroup_port_count_is,group_connector_scales_toandarista_first_group_is_52_sfp_plus_at_10g.Bandwidthis imported fromstd.measure(this is #12114's dropped import).Local control (seed
gunbc run, this head's binary): old test plus only theBandwidthimport →resolve failed … :183:75 value does not inhabit its declared type … declared List<Bandwidth>, produced Optional<List<Bandwidth>>. New test → resolves and the claim evaluatestrue.(2)
v2.lens.reference_depsadmission_from_module_rootThe earliest boundary that fails (§6b) is the module's import list, not the function.
reference_depsnever importedOutcome/Accepted/Rejected/Nonefromv2.std.diagnostic, soOutcome<Admission>was an unresolved name. The checker read it asPrimitive(T). Every otherOutcome<…>in the file passed vacuously the same way. Only this site produced aProduct(Admission) where the unresolved parameter was expected, so only this site reported. The fix is the import (this is #12114's droppedOutcome/Accepted), and the signature is correct as written.Why the floor never seeds this closure
compile_door_ledger_ownership_testis modulev2.test.compile_door_ledger_ownership. The"v2.test."row was withdrawn fromv2.workflow.required_floorrequired_gate_prefixes, as recorded in the comment beside it: 14.3 min of strict preparation over a 3,199-module closure. So the module is seeded only when its own file changes (changed-witness). No required lane type-checksv2.lens.reference_depsthrough this claim. That is the §3 inhabitance gap: a production module sits inside an enrolled claim's closure, and nothing checks it.Should a required lane reach it? Yes. The claim is the only enrolled route to
reference_deps→compile_door_ledger. The existing mechanism already covers it: the withdrawn"v2.test."row is named as "the first to return" once preparation is reused or diff-scoped. A narrower route is an exact-module selector (the second selector kind thatrequired_floordocuments). No job is added here, because new jobs need operator sign-off.Receipt
Floor log receipt: see the PR comment once this head's floor run lands.
🤖 Generated with Claude Code