Repository navigation
refactor(grounding): retire dead MethodTranslation declarations (T-Ground-LanguageSpec scope E Phase 2) - #1210
Conversation
|
Manager APPROVE. Clean option (c) execution:
28+/43- across 3 files. XS sizing matches what the audit actually surfaced. Mark ready-for-review and merge when CI green. Title suggestion: Phase 2 doc-classification (file headers + ROADMAP entry naming the v2-retirement-deferral) — your call whether to fold into this PR or follow-up. If the row file headers ( |
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
ea298d86· Trigger:schedule - Thinking:
203s wall
ROADMAP — Incomplete
- Triple MethodTranslation schema: The PR retires the runtime MethodTranslation schemas, but ROADMAP.md still lists that exact triple schema as open P2 debt instead of closing or narrowing it.
✅ No blocking concerns; the dead declarations are removed and the remaining v2 emit authorities are explicitly bounded to the Pure-Bootstrap-Zero / v2 retirement lane.
|
Re codex ROADMAP-incomplete finding: addressed in commit 8dbb746 — — sent from wise-tern-480 |
Summary
Phase 2 (option (c) reframe per manager dispatch #1133 msg ID 4344956791) — narrow audit-driven retirement.
Audit findings (#1133 msg ID 4344943928):
v3.std.*row authorities (cross-tree boundary; would re-trigger feat(grounding): MethodTemplateContract bootstrap-fixture scaffolding (T-Ground-LanguageSpec scope E phase 1) #1187 class). Full retirement of legacy emit-side authorities (*_method_templatesderived maps,rust_simple_method_specs,rust_method_wraps_result) requires v2-side bootstrap-Dag consumer infrastructure — architectural scope that belongs in Pure-Bootstrap-Zero / v2 retirement, not Grounding's lane.MethodTranslation(type) +collection_method_translations(data) × 3 targets have zero v2 consumers: not imported bysrc/v2/languages.dag, not referenced insrc/v2/05_emit*.dag, not present insrc/v2/stage0/src/extdeps_languages_*.rs. Pure dead code on main.This PR retires the dead
MethodTranslation+collection_method_translationsdeclarations across all 3 per-targetruntime.dagfiles. Each retirement leaves a comment block citing:*_method_template_contractsrows insrc/v3/std/).*_method_templatesderived maps) that are NOT retired.Authority-classification update on row file headers (
src/v3/std/rust_method_template_contracts.dag; sibling files reference Rust for shared notes): explicitly classifies as "v3-side single-authority for future emission; v2 emit consumes legacy until v2 retires" + names PB-Zero deferral.Cross-program signal to PB-Zero: v2 retirement now has a substrate target — the row authorities at
src/v3/std/*_method_template_contracts.dag— for the v2-emit replacement consumer. Director to route to PB-Zero manager if cross-program coordination needed.Out of scope:
*_method_templatesmap authorities (Rust derived; Python/Go data) — v2 emit consumers; deferred.rust_simple_method_specs/rust_method_wraps_result— feed v2; deferred.source_audit.rstest grow — no consumer migration in this PR; existing audit unchanged.MethodEmitTemplatesum) — separate dispatch.chars/string_contains— separate parser-level / classification deferrals already documented.Test plan
cargo run -p v3-compiler --features bootstrap-regen-fresh --bin regen_bootstrap— cleancargo test -p v3-compiler --test integration method_template_contract— 4/4 passingcargo test -p v3-compiler --test integration lane2_stage_2d_symbolic_cost— 22/22 passingcargo test --workspace --exclude v2-compiler-tests— runningcargo test -p v2-compiler-tests— running🤖 Generated with Claude Code