Skip to content

Main repair: hoist the in-body annotation in target_invocation_witness_test #11969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
briansrls merged 1 commit into from
Sep 21, 2026
Merged

Main repair: hoist the in-body annotation in target_invocation_witness_test #11969

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions dag/test/claim/target_invocation_witness_test.dag
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -806,6 +806,11 @@ test fn the_bare_channel_rendering_names_the_channel_and_the_pull_set() -> Bool
// THE ROW IS REAL ON THE SAME SEAM ITS SIBLINGS USE: the label is canonical and the registry the
// production entry builds admits it, so a binding that never reached `instrument_bindings()` reds
// here rather than being discovered at the first invocation.
//
// THE SUBJECT IS THE FIXTURE ROOT AND NOTHING ELSE, which is what makes this instrument's reading
// stable: a corpus-wide change cannot move it, so a moved reading means a moved gate. An
// invocation that reached `dag` would be measuring a different population under this target's
// name -- hence the last conjunct pins the source roots.
test fn the_bare_channel_instrument_is_a_real_row_on_the_shared_registry() -> Bool {
let label = bare_reference_channel_outcome_label()
(match label_canonicality(label: label) {
Expand All @@ -819,10 +824,6 @@ test fn the_bare_channel_instrument_is_a_real_row_on_the_shared_registry() -> Bo
&& label_eq(a: b.target, b: label)
TargetInvocationRouteRefused { cause: _ } => false
})
// THE SUBJECT IS THE FIXTURE ROOT AND NOTHING ELSE, which is what makes this instrument's
// reading stable: a corpus-wide change cannot move it, so a moved reading means a moved gate.
// An invocation that reached `dag` would be measuring a different population under this
// target's name.
&& (bare_reference_channel_source_roots() == ["fixtures/bare_reference_channel"])
}

Expand Down