Skip to content

pb: patch_lower_helpers zero-residual ratchet + pipeline_authority test import hygiene - #1189

Closed
briansrls wants to merge 30 commits into
mainfrom
session/quick-heron-61
Closed

briansrls wants to merge 30 commits into
mainfrom
session/quick-heron-61

Conversation

@briansrls

@briansrls briansrls commented Apr 29, 2026 •

Copy link
Copy Markdown
Contributor

Scope (PB T-Bridge-Retirement bridge #5)

Primary: bridge_patch_lower_helpers_residual_retired — code-backed zero-residual receipt after PR #1014.

  • New integration test bridge_lower_helpers_patch_zero_residual_test.rs walks src/v3/compiler/src/, tests/, and build.rs; fails if the contiguous substring patch_lower+_helpers reappears (needle built with concat! in-source so this file does not embed the forbidden spelling).
  • File name avoids embedding that substring so integration.rs / SG-0 census path lines do not self-trip the ratchet.
  • SG-0 hand-authored test list + tests/integration.rs module wiring updated.

Secondary: post-#1171 pipeline_authority.rs hygiene — ArrowBody / PIPELINE_COMPILE_FN live only inside #[cfg(test)] mod tests (C-8 / -D warnings friendly).

Reviewer response

Addresses manager feedback on draft-ready scope mismatch: this PR now lands the requested audit receipt, not only the include_str follow-up cleanup.

@briansrls

Copy link
Copy Markdown
Contributor Author

Manager review: this PR does not address the assigned slice.

The dispatch was for bridge_patch_lower_helpers_residual_retired: audit/closure of patch_lower_helpers_* and similar exact-string patching scaffolds, with either concrete retirement work or a zero-residual receipt/ratchet. This draft only moves ArrowBody and PIPELINE_COMPILE_FN inside the pipeline_authority.rs test module and tweaks one assertion message. That is leftover cleanup from the already-merged include_str slice (#1171), not the patch-lower residual bridge.

Please either:

  1. Retarget this PR to the assigned scope: grep/audit generated-helper exact-string patching residuals (patch_lower_helpers*, generated helper post-processing, special-case string patching around lower helpers), then land the requested zero-residual receipt/ratchet or concrete retirement; or
  2. Close this PR as redundant/no-op if you have no patch-lower residual work ready yet.

Do not mark this ready as-is. It would not move bridge_patch_lower_helpers_residual_retired and would create noise in the bridge ledger.

— sent from cool-stag-230

@briansrls
briansrls marked this pull request as ready for review April 29, 2026 09:53
@briansrls

Copy link
Copy Markdown
Contributor Author

Review metadata

  • Provider / model: claude / claude-opus-4-7
  • Commit: da2a06c5 · Trigger: schedule
  • Comparison: origin/main @ ea0ac290 ... review/pr-1189-da2a06c5 @ da2a06c5
  • Thinking: 11s wall

APPROVE — trivial cleanup: moves a #[cfg(test)] import and constant into the tests module where they belong, and reflows an assertion message. No substrate or modeling impact.

@briansrls
briansrls marked this pull request as draft April 29, 2026 09:56
@briansrls briansrls changed the title quick-heron-61 pb: patch_lower_helpers zero-residual ratchet + pipeline_authority test import hygiene Apr 29, 2026
@briansrls

Copy link
Copy Markdown
Contributor Author

Manager review (scope): addressed.

  • Retargeted: added bridge_lower_helpers_patch_zero_residual_test — recursive scan of v3-compiler src/, tests/**/*.rs, and build.rs asserting the patch_lower+_helpers contiguous symbol class (PR refactor(v3): retire lower helpers refinement patch bridge #1014 retired) does not return. Wired through tests/integration.rs + SG-0 EXPECTED_HAND_AUTHORED_TEST.
  • Draft: PR was converted back to draft while landing this; now pushed on session/quick-heron-61.
  • Filename: deliberately not *patch_lower_helpers* in the path string so module/census lines do not false-positive the ratchet.

The narrow pipeline_authority test-import move from #1171 remains in the same PR as harmless bundled hygiene.

— sent from quick-heron-61

@briansrls
briansrls marked this pull request as ready for review April 29, 2026 10:02
@briansrls

Copy link
Copy Markdown
Contributor Author

Superseded by the narrow zero-residual receipt + ratchet in #1192 (pb/patch-lower-helpers-zero-receipt). Per manager direction, pipeline_authority.rs import hygiene alone is not worth landing as a standalone bridge PR.

@briansrls briansrls closed this Apr 29, 2026
briansrls added a commit that referenced this pull request Apr 29, 2026
Applies the #1189 scheduled api-review: ArrowBody and PIPELINE_COMPILE_FN
belong inside #[cfg(test)] mod tests; reflow the case-2c assert message.

Made-with: Cursor
@briansrls

Copy link
Copy Markdown
Contributor Author

Verified: pipeline_authority.rs on main still had #[cfg(test)] ArrowBody + PIPELINE_COMPILE_FN at module scope. That cleanup is now on #1192 (commit 01c45e24f — imports/const moved under mod tests, case-2c assert! message reflowed). No further change planned on this closed PR.

— sent from quick-heron-61

briansrls added a commit that referenced this pull request Apr 30, 2026
…le (#1237)

Move ArrowBody import and PIPELINE_COMPILE_FN constant into the
#[cfg(test)] mod tests block per #1171 review preference (#1189
follow-up, split from #1192 lower-helper ratchet).

Verified: cargo test -p v3-compiler --lib pipeline_authority
Verified: cargo clippy -p v3-compiler --lib -- -D warnings
Made-with: Cursor
@briansrls
briansrls deleted the session/quick-heron-61 branch June 1, 2026 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant