Skip to content

main repair: hoist a body-scope annotation in roadmap_review_function_witness_test (floor refuses to parse since #11761) - #11831

Merged
briansrls merged 1 commit into
mainfrom
session/sharp-ibex-174-review-witness-annotation
Sep 20, 2026
Merged

briansrls merged 1 commit into
mainfrom
session/sharp-ibex-174-review-witness-annotation

Conversation

@gunbai-bot

@gunbai-bot gunbai-bot Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

Main is parse-broken at dag/test/claim/roadmap/roadmap_review_function_witness_test.dag:117-124 since #11761: an eight-line // block sits inside a test fn body, and DESIGN §4c admits annotations only at module-item grain. Consequence: the required floor refuses every run (FAILED PHASE parse (8 error(s)) → ArmSetConsumerPlanningUnavailable) and evaluates no claim.

Nobody saw it because the gate was fail-open — see #11829. The first floor run with the adjudicator bound (#11829, run 35498822130) went RED on exactly this, which is the lane-grain discriminating red that PR owed.

This PR hoists the block above the declaration it describes. No other change. v1_src_dag_parse sweep is clean for the file.

🤖 Generated with Claude Code

…_witness_test to module scope

#11761 left an eight-line // block inside
the_aggregate_regroups_by_file_counts_the_overlap_and_names_the_incomplete_calls;
DESIGN 4c admits annotations only at module-item grain, so the file
refuses to parse (8 errors) and the required floor refuses every run
with ArmSetConsumerPlanningUnavailable. Nobody saw it because the gate
was fail-open (#11829): floor refused, lane green. Measured on #11829's
first run 35498822130, the first floor run with an adjudicator bound,
which went RED on exactly this.

The block moves above the declaration it describes; no other change.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@gunbai-bot

gunbai-bot Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor Author

Executed: run 35499716882, floor job, Nominal step log:

[floor-phase] phase=site-projection state=completed ... claims=402 ...
[changed-witness] identity=test.claim.roadmap.roadmap_review_function_witness_test.the_aggregate_regroups_by_file_counts_the_overlap_and_names_the_incomplete_calls standing=planned-and-passed disposition=planned_as_changed_wit...
required-ci: lane=witnesses phases_run=2 phases_failed=0

versus FAILED PHASE parse (8 error(s)) / phases_failed=2 on every floor since #11761 (e.g. #11829 run 35498822130, #11821 run 35497139573). The floor plans and evaluates claims again on this head. (This PR's green check is still the fail-open green until #11829 lands — the line above is the evidence, not the check.)

@briansrls
briansrls added this pull request to the merge queue Sep 20, 2026
Merged via the queue into main with commit ebaf85a Sep 20, 2026
4 checks passed
@briansrls
briansrls deleted the session/sharp-ibex-174-review-witness-annotation branch September 20, 2026 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant