Skip to content

Hoist a body annotation to module scope: main's parse phase refuses it, leaving every PR's floor with no declaration index #11822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gunbai-bot merged 1 commit into from
Sep 20, 2026
Merged

Hoist a body annotation to module scope: main's parse phase refuses it, leaving every PR's floor with no declaration index #11822

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions dag/test/claim/roadmap/roadmap_review_function_witness_test.dag
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,14 @@ test fn the_join_keeps_the_plan_as_denominator_and_refuses_foreign_or_duplicate_

// THE FOLD: findings regroup by file for the worker, identical rows fold once, a file named by two
// criteria is the counted residual, and an early report says which calls are still incomplete.
// THE COUNT IS DERIVED, NOT TRANSCRIBED. This asserted the literal "Still reviewing (10 ...)"
// followed by all ten key names in roster order, both copied from the live criteria roster. That
// made it a change detector for roster SIZE: adding any reviewer to a design row broke it, and
// the repair was to retype the number -- which DESIGN section 5 names outright, since automating
// the literal's update collapses the assertion to measure() == measure(). Four of this scenario's
// five observations are terminal (the fifth is still running), so the incomplete set is the
// roster minus those four, and that relation is what the fold actually owes. The rendering is
// still covered: the phrase must appear and must name a criterion that had no observation.
test fn the_aggregate_regroups_by_file_counts_the_overlap_and_names_the_incomplete_calls() -> Bool {
let p = plan()
let running = ReviewObservation { call_id: "how-to-work", subject_id: review_subject_id(s: p.subject), plan_revision: p.revision, source: ReviewReceiptAbsent, process: WorkerProcessRunning { command: "gunbc" as NonEmptyStr } }
Expand All @@ -114,14 +122,6 @@ test fn the_aggregate_regroups_by_file_counts_the_overlap_and_names_the_incomple
&& any(f.incomplete, k => k == "conformance-extdeps")
&& string_contains(s: text, pattern: "Fix, by file: dag/y.dag — minimize-redundancy: changes requested — a copied fold · dag/x.dag — single-authority: changes requested — a second name for one concept; fail-closed: changes requested — an arm widens")
&& string_contains(s: text, pattern: "1 file(s) were named by more than one criterion")
// THE COUNT IS DERIVED, NOT TRANSCRIBED. This asserted the literal "Still reviewing (10 ...)"
// followed by all ten key names in roster order, both copied from the live criteria roster. That
// made it a change detector for roster SIZE: adding any reviewer to a design row broke it, and
// the repair was to retype the number -- which DESIGN section 5 names outright, since automating
// the literal's update collapses the assertion to measure() == measure(). Four of this scenario's
// five observations are terminal (the fifth is still running), so the incomplete set is the
// roster minus those four, and that relation is what the fold actually owes. The rendering is
// still covered: the phrase must appear and must name a criterion that had no observation.
&& count(f.incomplete) == count(review_criteria) - 4
&& string_contains(s: text, pattern: ", this report is not complete): ")
&& string_contains(s: text, pattern: "conformance-extdeps")
Expand Down