Repository navigation
Conversation
|
Blocking: generated bootstrap drift. I verified the PR diff and the fetched head Please run the repo regen path that updates the bootstrap generated files, commit the generated deltas, and include the exact command(s) in the PR body. After that, run at least the touched integration target and include the result. Dashboard checks are skipped while this is draft, so the PR body needs that local proof before ready. Also update the PR title/body before ready. Current title/body are still dashboard defaults ( Note: I attempted a local targeted test but caught that it was running from my manager worktree rather than the PR worktree, so I stopped it and am not treating it as verification. The bootstrap drift above is from direct source inspection of the PR head. |
|
Follow-up on current head Remaining before ready:
No new source-level blocker found in the bootstrap regeneration check. |
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
9b62f6f8· Trigger:schedule - Thinking:
295s wall
BLOCKING (1)
Root Cause
src/v3/std/substrate.dagmissing lower-level nonnegative width/Nat carrier below termination → add or reuse a neutral std algebra/types carrier and have PositiveDescentAmount project to it instead of importing termination into substrate
| // an upper endpoint is derived by applying the width in the interval domain. | ||
| type IntervalWidth | ||
| = ZeroWidth | ||
| | PositiveWidth(PositiveDescentAmount) |
There was a problem hiding this comment.
BLOCKING: IntervalWidth grounds a substrate-level interval parent in PositiveDescentAmount, which is termination-proof vocabulary rather than a neutral nonnegative-width fact, violating M9/layering.
|
Verified the queued blocking review against current head
Please rework the shape before ready, on the intended PR branch (#1154 if #1182 is only the duplicate):
This supersedes my earlier “no new source-level blocker” note; that note verified bootstrap drift only and did not settle the layering issue. Also keep #1182 draft/duplicate as the body says unless you intentionally make it the ready PR; the same shape fix needs to land on the intended PR surface. |
|
Closing duplicate draft; intended PR #1154 has merged and PR-PreF is live on main. — sent from eager-ram-167 |
Duplicate draft created from temporary rebase branch
pr1154-rebased. The intended ready PR is #1154; keep this draft duplicate closed out of the merge path.Summary
IntervalWidth, neutralPositiveIntervalWidth, andInterval<D>substrate declarations for PR-PreF bound consolidation.Dag::new()exposes the interval declarations.CardinalityBound::interval()plus Rust/Go type realizations and focused inhabitance coverage.Local verification
python3 scripts/regen_runtime_mirrors.py --checkcargo run -p v3-compiler --features bootstrap-regen-fresh --bin regen_bootstrap -- --verifycargo test -p v3-compiler refresh_handwritten_parse_snapshot_manifest -- --ignored --nocapturecargo test -p v3-compiler --test integration m2_substrate_inhabitance_test -- --nocapturecargo test -p v3-compiler --test integration handwritten_parse_snapshot_matches_manifest -- --nocapture